Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0][MIG] hr_commission module #120

Closed
wants to merge 4 commits into from

Conversation

cubells
Copy link
Sponsor Member

@cubells cubells commented Apr 25, 2017

  • Update README
  • Update views
  • Remove unnecessary fields
  • Update po files

Depends on:

cc @Tecnativa

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little change

@@ -22,11 +22,6 @@ msgid "There must one (and only one) employee linked to this partner. To do this
msgstr ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file

@cubells
Copy link
Sponsor Member Author

cubells commented May 31, 2017

@pedrobaeza done

@pedrobaeza
Copy link
Member

@luismontalba can you review?

@luismontalba
Copy link
Member

I try to test on runbot but the module can't finish complete installation ..

@pedrobaeza
Copy link
Member

@cubells see the problem in runbot to help @luismontalba to test this.

@cubells
Copy link
Sponsor Member Author

cubells commented Aug 9, 2017

Runbot fails due to:

ERROR openerp_test openerp.modules.graph: module hr_commission: Unmet dependencies: sale_commission

But sale_commission pr is merged.

@pedrobaeza
Copy link
Member

You haven't rebased.

@cubells
Copy link
Sponsor Member Author

cubells commented Aug 9, 2017

I've rebased and same error. Am I doing something
wrong or is it runbot?

@pedrobaeza
Copy link
Member

Close this PR and open a new one to see if it's a runbot problem.

@pedrobaeza pedrobaeza closed this Aug 9, 2017
@cubells cubells mentioned this pull request Aug 10, 2017
@yajo yajo deleted the 9.0-mig-hr_commission branch August 25, 2017 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants