New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0][MIG] hr_commission module #120

Closed
wants to merge 4 commits into
base: 9.0
from

Conversation

Projects
None yet
4 participants
@cubells
Member

cubells commented Apr 25, 2017

  • Update README
  • Update views
  • Remove unnecessary fields
  • Update po files

Depends on:

cc @Tecnativa

@pedrobaeza pedrobaeza referenced this pull request May 16, 2017

Closed

[MIG][9.0] hr_commission #74

@pedrobaeza

Little change

Show outdated Hide outdated hr_commission/i18n/hr_commission.pot
@cubells

This comment has been minimized.

Show comment
Hide comment
@cubells
Member

cubells commented May 31, 2017

@pedrobaeza

This comment has been minimized.

Show comment
Hide comment
@pedrobaeza

pedrobaeza Jun 8, 2017

Contributor

@luismontalba can you review?

Contributor

pedrobaeza commented Jun 8, 2017

@luismontalba can you review?

@luismontalba

This comment has been minimized.

Show comment
Hide comment
@luismontalba

luismontalba Jun 9, 2017

Member

I try to test on runbot but the module can't finish complete installation ..

Member

luismontalba commented Jun 9, 2017

I try to test on runbot but the module can't finish complete installation ..

@pedrobaeza

This comment has been minimized.

Show comment
Hide comment
@pedrobaeza

pedrobaeza Aug 8, 2017

Contributor

@cubells see the problem in runbot to help @luismontalba to test this.

Contributor

pedrobaeza commented Aug 8, 2017

@cubells see the problem in runbot to help @luismontalba to test this.

@cubells

This comment has been minimized.

Show comment
Hide comment
@cubells

cubells Aug 9, 2017

Member

Runbot fails due to:

ERROR openerp_test openerp.modules.graph: module hr_commission: Unmet dependencies: sale_commission

But sale_commission pr is merged.

Member

cubells commented Aug 9, 2017

Runbot fails due to:

ERROR openerp_test openerp.modules.graph: module hr_commission: Unmet dependencies: sale_commission

But sale_commission pr is merged.

@pedrobaeza

This comment has been minimized.

Show comment
Hide comment
@pedrobaeza

pedrobaeza Aug 9, 2017

Contributor

You haven't rebased.

Contributor

pedrobaeza commented Aug 9, 2017

You haven't rebased.

@cubells

This comment has been minimized.

Show comment
Hide comment
@cubells

cubells Aug 9, 2017

Member

I've rebased and same error. Am I doing something
wrong or is it runbot?

Member

cubells commented Aug 9, 2017

I've rebased and same error. Am I doing something
wrong or is it runbot?

@pedrobaeza

This comment has been minimized.

Show comment
Hide comment
@pedrobaeza

pedrobaeza Aug 9, 2017

Contributor

Close this PR and open a new one to see if it's a runbot problem.

Contributor

pedrobaeza commented Aug 9, 2017

Close this PR and open a new one to see if it's a runbot problem.

@pedrobaeza pedrobaeza closed this Aug 9, 2017

@cubells cubells referenced this pull request Aug 10, 2017

Merged

[9.0][MIG] hr_commission #130

@Yajo Yajo deleted the Tecnativa:9.0-mig-hr_commission branch Aug 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment