[MIG][9.0] sale_commission #67
Conversation
| { | ||
| 'name': 'Sales commissions', | ||
| 'version': '8.0.2.0.0', | ||
| 'version': '8.0.2.3.0', |
|
This one is ready for reviewing. @oihane, please confirm from your side. From mine, it's 👍 |
| # License AGPL-3 - See http://www.gnu.org/licenses/agpl-3.0.html | ||
|
|
||
| { | ||
| 'name': 'Sales commissions', | ||
| 'version': '8.0.2.3.0', | ||
| 'version': '9.0.1.0.0', | ||
| 'author': 'Pexego, ' | ||
| 'Savoire-faire linux, ' |
* Change in author name * deleted company from contributors in openerp file * added settlement to partner view * erase dead code
|
I just tested in runbot and local with Odoo Enterprise and this is the results: 1- There is an issue in Odoo Enterprise in Commission types form view:
2- When you create a sale order and click to edit an already created sale order line the Agents & Commission Fields get a duplicated record and it doubles every time you try to edit a sale.order.line |
|
@oihane are you still working on this PR?... I already fix the first issue I posted, there is a way that I can help to this PR? or I need to make a new PR with this + my fix.??? |
|
@alan196 you can make a PR against my branch, then I merge it and the changed will be shown in this PR. |
|
@alan196 you have been invited as collaborator to my fork, so you can now edit the code in this PR. Can the second point be a problem caused by the _default??? |
|
+1 |
|
@oihane I think is a bug of Odoo with the one2many widget inside tree view. I don't know how to solve it |
|
In v8 we have switched to a new widget one2many_tags |
|
@pedrobaeza I already try with that widget and I get the same issue and it also looks ugly.
|
|
Does it happen also in community edition? |
|
Yes it also looks like that in community edition.
I have another question. Can I use the same branch to change the code to fit the conventions? for example to change all the relational fields to _id or _ids. |
|
If you changed that, you should put |
|
@pedrobaeza @oihane Why "sale.commission.company_id" has been removed in v9? |
|
It hasn't been removed, but added in v8 after this migration. |
|
We have to cherry-pick that commits. |
|
Closing as superseeded by #72 |
|
@oihane any possibility of starting the migration once again for v9.0 with the superseded commits from #72? @pedrobaeza IMO, we could have merged this PR and create a new PR containing the bug fixes in v8.0 using cherry-pick. |
|
@atchuthan, there's another PR already merged. What you can do is to make another PR with the rest of the changes. |
|
I have mixed PRs, as the other was only latest changes from the 8.0 branch, so this branch is still relevant. I reopen the PR. |
|
@pedrobaeza thanks for re-opening it. |
|
Functional Test(locally) + code review 👍 Seems OCA runbot fails due to skipped[unknown reason] (Tried 2 times) |
|
@pedrobaeza Could we merge this PR as we have 4 Upvote in this PR? |
|
hi @oihane @pedrobaeza i've tried locally to reproduce the travis error but i can't and the test run perfectly. |
|
Just tried to restart jobs with red build. Let's see! |
|
@pedrobaeza, Travis now looks green, could we merge it? |
|
We are going to merge this one and we will improve it when the widget is available. |
No description provided.