Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.0][MIG] hr_commission #130

Merged
merged 4 commits into from
Aug 10, 2017
Merged

[9.0][MIG] hr_commission #130

merged 4 commits into from
Aug 10, 2017

Conversation

cubells
Copy link
Member

@cubells cubells commented Aug 10, 2017

  • Update README
  • Update views
  • Remove unnecessary fields
  • Update po files
  • Add tests

related: #120

cc @Tecnativa

@cubells
Copy link
Member Author

cubells commented Aug 10, 2017

@luismontalba can you review now?

luismontalba
luismontalba approved these changes Aug 10, 2017
View reviewed changes
Copy link
Member

@luismontalba luismontalba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runbot

@cubells cubells changed the title 9.0 mig hr commission new [9.0][MIG] hr_commission Aug 10, 2017
pedrobaeza
pedrobaeza approved these changes Aug 10, 2017
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this comes from the other PR with old history, I proceed to merge.

@pedrobaeza pedrobaeza merged commit bd0d52d into OCA:9.0 Aug 10, 2017
@pedrobaeza pedrobaeza deleted the 9.0-mig-hr_commission_new branch August 10, 2017 15:41
@pedrobaeza pedrobaeza mentioned this pull request Aug 10, 2017
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luismontalba luismontalba luismontalba approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cubells @luismontalba @pedrobaeza @oca-transbot