Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0][MIG] contract_commission module #119

Merged
merged 3 commits into from
Jul 2, 2017

Conversation

cubells
Copy link
Sponsor Member

@cubells cubells commented Apr 5, 2017

-Updated README

Depends on:

cc @Tecnativa

@cubells cubells force-pushed the 9.0-mig-contract_comission branch from 1240bb6 to d84f66d Compare April 5, 2017 17:10
Contributors
------------
* Pedro M. Baeza <pedro.baeza@serviciosbaeza.com>
* Vicent Cubells <vicent.cubells@serviciosbaeza.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put tecnativa.com

* http://commons.wikimedia.org/wiki/File:Percent_18e.svg
* https://openclipart.org/detail/43969/pile-of-golden-coins-by-j_alves
* Subicon made by `Freepik <http://www.flaticon.com/authors/freepik>_ from
www.flaticon.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End URL with final `

@cubells cubells force-pushed the 9.0-mig-contract_comission branch from d84f66d to 58ddaea Compare May 17, 2017 08:40
pedrobaeza and others added 2 commits July 1, 2017 13:30
=======================
Commission in contracts
=======================

This module allows to get default commissions for partner in the recurring
invoices generated from contracts.

Installation
============

This module is auto-installed when you have *account_analytic_analysis* and
*sale_commission* modules installed.

Usage
=====

When invoicing contracts, the agents assigned to the partner of the contract
will now be assigned to the generated invoices.
@pedrobaeza
Copy link
Member

@luismontalba please review

Copy link

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small details. other than that, LGTM

Known issues / Roadmap
======================

* Allow to set specific commissions for each contract instead taking the ones

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of

----
* http://commons.wikimedia.org/wiki/File:Percent_18e.svg
* https://openclipart.org/detail/43969/pile-of-golden-coins-by-j_alves
* Subicon made by `Freepik <http://www.flaticon.com/authors/freepik>_ from

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your URL is wrong. Should be better something like

* Subicon made by `Freepik  from www.flaticon.com <http://www.flaticon.com/authors/freepik>`_

@cubells cubells force-pushed the 9.0-mig-contract_comission branch from c77ce9b to 9fb1883 Compare July 2, 2017 09:29
@cubells
Copy link
Sponsor Member Author

cubells commented Jul 2, 2017

@elicoidal done!

@pedrobaeza pedrobaeza merged commit 2c50300 into OCA:9.0 Jul 2, 2017
@pedrobaeza pedrobaeza deleted the 9.0-mig-contract_comission branch July 2, 2017 12:42
@pedrobaeza pedrobaeza mentioned this pull request Jul 2, 2017
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants