Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0] [MIG] Contract Mandate #238

Merged
merged 7 commits into from
Oct 1, 2019
Merged

[12.0] [MIG] Contract Mandate #238

merged 7 commits into from
Oct 1, 2019

Conversation

ThomasBinsfeld
Copy link
Contributor

@ThomasBinsfeld ThomasBinsfeld commented Dec 20, 2018 •
edited
Loading

This work is based on the contract_mandate 10.0 migration: #113

@pedrobaeza pedrobaeza added this to the 12.0 milestone Dec 20, 2018
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 20, 2018
Closed
19 tasks
@ThomasBinsfeld ThomasBinsfeld mentioned this pull request Jan 8, 2019
Merged
nikul-serpentcs
nikul-serpentcs reviewed May 29, 2019
View reviewed changes
Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking

contract_mandate/models/contract.py Show resolved Hide resolved
@rafaelbn
Copy link
Member

Hi @ThomasBinsfeld I would like to test this one when runbots is 🍏

@rafaelbn rafaelbn self-requested a review August 18, 2019 10:50
@sbejaoui
Copy link
Contributor

Hi @ThomasBinsfeld I would like to test this one when runbots is

@rafaelbn
Runbot is green, you can test it now

nikul-serpentcs
nikul-serpentcs approved these changes Oct 1, 2019
View reviewed changes
Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review LGTM 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

gva-acsone
gva-acsone approved these changes Oct 1, 2019
View reviewed changes
Copy link

@gva-acsone gva-acsone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test +1

@sbejaoui sbejaoui merged commit da60325 into OCA:12.0 Oct 1, 2019
@ThomasBinsfeld ThomasBinsfeld deleted the 12.0-mig_contract_mandate_tbi branch October 1, 2019 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbejaoui sbejaoui sbejaoui approved these changes

@nikul-serpentcs nikul-serpentcs nikul-serpentcs approved these changes

@gva-acsone gva-acsone gva-acsone approved these changes

@rafaelbn rafaelbn Awaiting requested review from rafaelbn

Assignees
No one assigned
Labels
approved needs review ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.
9 participants
@ThomasBinsfeld @rafaelbn @sbejaoui @OCA-git-bot @nikul-serpentcs @gva-acsone @pedrobaeza @carlosdauden @oca-transbot