Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0] [MIG] Contract Payment Mode #236

Merged
merged 16 commits into from
Oct 1, 2019
Merged

[12.0] [MIG] Contract Payment Mode #236

merged 16 commits into from
Oct 1, 2019

Conversation

ThomasBinsfeld
Copy link
Contributor

@ThomasBinsfeld ThomasBinsfeld commented Dec 18, 2018 •
edited

No description provided.

@pedrobaeza pedrobaeza added this to the 12.0 milestone Dec 18, 2018
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 18, 2018
Closed
19 tasks
@ThomasBinsfeld ThomasBinsfeld force-pushed the 12.0-mig_contract_payment_mode_tbi branch from 494ef1c to d45f600 Compare December 18, 2018 12:56
@ThomasBinsfeld ThomasBinsfeld mentioned this pull request Dec 20, 2018
Merged
@sbidoul
Copy link
Member

sbidoul commented Dec 27, 2018

@ThomasBinsfeld can you check the failing test?

@ThomasBinsfeld ThomasBinsfeld force-pushed the 12.0-mig_contract_payment_mode_tbi branch from d45f600 to ab327a5 Compare January 7, 2019 10:50
@ThomasBinsfeld ThomasBinsfeld force-pushed the 12.0-mig_contract_payment_mode_tbi branch from ab327a5 to f952618 Compare January 16, 2019 13:03
@ThomasBinsfeld
Copy link
Contributor Author

@sbidoul Unit tests should be green when rebased on #207

@ThomasBinsfeld ThomasBinsfeld force-pushed the 12.0-mig_contract_payment_mode_tbi branch 5 times, most recently from 9531b55 to 7a5b724 Compare January 30, 2019 09:29
MiquelRForgeFlow
MiquelRForgeFlow approved these changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review LGTM

@sbidoul please remove "needs fixing" tag

pedrobaeza
pedrobaeza reviewed Apr 23, 2019
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
AaronHForgeFlow
AaronHForgeFlow approved these changes May 28, 2019
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only functional review. It works fine.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ThomasBinsfeld ThomasBinsfeld force-pushed the 12.0-mig_contract_payment_mode_tbi branch from 7a5b724 to 6a66540 Compare May 29, 2019 10:34
nikul-serpentcs
nikul-serpentcs reviewed May 29, 2019
View reviewed changes
Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking

contract_payment_mode/__manifest__.py Outdated Show resolved Hide resolved
@ThomasBinsfeld ThomasBinsfeld force-pushed the 12.0-mig_contract_payment_mode_tbi branch from 6a66540 to 538a38f Compare May 29, 2019 13:13
nikul-serpentcs
nikul-serpentcs approved these changes May 29, 2019
View reviewed changes
Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only Code Review LGTM 👍

Squash Commit's

@ThomasBinsfeld ThomasBinsfeld force-pushed the 12.0-mig_contract_payment_mode_tbi branch from 538a38f to 713e470 Compare May 29, 2019 15:11
HviorForgeFlow
HviorForgeFlow reviewed May 31, 2019
View reviewed changes
Copy link
Member

@HviorForgeFlow HviorForgeFlow left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing

@sbejaoui @pedrobaeza
Fix unit test
c871e2b 
Co-Authored-By: Pedro M. Baeza <pedro.baeza@tecnativa.com>
@sbejaoui
Copy link
Contributor

sbejaoui commented Sep 30, 2019 •
edited

@OCA/core-maintainers

This PR is ready to be merged.

@moylop260
Copy link

/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-236-by-moylop260-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 30, 2019
@OCA-git-bot
Merge PR #236 into 12.0
b3029af 
Signed-off-by moylop260
@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-236-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 30, 2019
@OCA-git-bot
Merge PR #236 into 12.0
b5600b1 
Signed-off-by pedrobaeza
rafaelbn
rafaelbn approved these changes Sep 30, 2019
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-236-by-moylop260-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 1, 2019
@OCA-git-bot
Merge PR #236 into 12.0
b6dfe01 
Signed-off-by moylop260
OCA-git-bot added a commit that referenced this pull request Oct 1, 2019
@OCA-git-bot
Merge PR #236 into 12.0
69e643f 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-236-by-pedrobaeza-bump-no, awaiting test results.

@OCA-git-bot
Copy link
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-236-by-moylop260-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 1, 2019
@OCA-git-bot
Merge PR #236 into 12.0
58b2557 
Signed-off-by moylop260
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-236-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 1, 2019
@OCA-git-bot
Merge PR #236 into 12.0
4c717a7 
Signed-off-by pedrobaeza
@sbejaoui sbejaoui merged commit 6f6fd45 into OCA:12.0 Oct 1, 2019
@ThomasBinsfeld ThomasBinsfeld deleted the 12.0-mig_contract_payment_mode_tbi branch October 1, 2019 07:32
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-236-by-moylop260-bump-no, awaiting test results.

@OCA-git-bot
Copy link
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-236-by-pedrobaeza-bump-no, awaiting test results.

@OCA-git-bot
Copy link
Contributor

@moylop260 your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-236-by-moylop260-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-236-by-pedrobaeza-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza left review comments

@HviorForgeFlow HviorForgeFlow HviorForgeFlow left review comments

@rafaelbn rafaelbn rafaelbn approved these changes

@sbejaoui sbejaoui sbejaoui approved these changes

@nikul-serpentcs nikul-serpentcs nikul-serpentcs approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

@OCA-git-bot OCA-git-bot Awaiting requested review from OCA-git-bot

Assignees

@ThomasBinsfeld ThomasBinsfeld

Labels
approved ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet