Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0] [MIG] contract_section #264

Closed

Conversation

Nikul-Chaudhary
Copy link
Member

Contracts Management - Add section to invoice lines

Enable the use of sections on the contract and the contract template.

@Nikul-Chaudhary Nikul-Chaudhary mentioned this pull request Jan 23, 2019
19 tasks
@pedrobaeza pedrobaeza added this to the 12.0 milestone Jan 23, 2019
@Nikul-Chaudhary
Copy link
Member Author

@pedrobaeza I have a doubt Regarding this module.

In v12 sale.layout_category model is deleted/Deprecated.

Here Can you please help me, What can i Do

@pedrobaeza
Copy link
Member

You have to switch to the same approach: having special contract lines for indicating a section, and generate that as the same special type invoice lines. It's a lot of work to do, I know.

@Nikul-Chaudhary
Copy link
Member Author

You have to switch to the same approach: having special contract lines for indicating a section, and generate that as the same special type invoice lines. It's a lot of work to do, I know.

Ok, I create a new object like this sale.layout_category, Right?

@pedrobaeza
Copy link
Member

No, just add a field in the contract line for indicating the type (just like in sale.order.line and account.invoice.line), and adapt the interface for adding multiple options to add a line (again the same as in sales and invoices). Then propagate this field the same as the others to the invoice line.

Finally, you have to make a migration script for transforming old contract sections to this new one (although you can leave this one being too much work).

@Nikul-Chaudhary
Copy link
Member Author

Nikul-Chaudhary commented Jan 24, 2019

@pedrobaeza layout_category_id field in two model.
1 for account.invoice.line
https://github.com/OCA/OpenUpgrade/blob/12.0/addons/sale/migrations/12.0.1.1/openupgrade_analysis.txt#L2
2 for sale.order.line
https://github.com/OCA/OpenUpgrade/blob/12.0/addons/sale/migrations/12.0.1.1/openupgrade_analysis.txt#L36

So, IMO I create a new field like layout_category_id and adding above model.

No, just add a field in the contract line for indicating the type

Which field??

@pedrobaeza
Copy link
Member

As said, in v12 there's a new field display_type. Please study a bit more how it works in v12 or dismiss the migration.

@Nikul-Chaudhary
Copy link
Member Author

Nikul-Chaudhary commented Jan 24, 2019

@pedrobaeza Can you Please take a look?

If not Correct then Close it.

@pedrobaeza
Copy link
Member

Can you please enable the same system as in sales order/invoices (with multiple "Add..." options in the one2many tree)?

seleccion_039

And check also if that is protected by any security group (I think not).

@Nikul-Chaudhary
Copy link
Member Author

@pedrobaeza Noted!

@pedrobaeza
Copy link
Member

Sections are already handled in standard contractmodule, so no need of this module anymore.

@pedrobaeza pedrobaeza closed this Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants