-
-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] agreement: Migration to 12.0 #287
Conversation
@max3903 @bealdav @alexis-via @pedrobaeza |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for porting this.
Just small comments to improve override with other module.
@ygol Please Add README.rst file. |
requested by @bealdav
Adding reference to #189 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few changes in the manifest. Otherwise LGTM
@bealdav @murtuzasaleh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On my side it's OK, but I haven't seen you don't have done a normal migration from old commits and add your migration commits.
It's not a problem for me, I'm not the original author, then I approve.
Thanks a lot
This PR has the |
@alexis-via Can you please merge this PR. |
Syncing from upstream OCA/contract (15.0)
I started over. Replacing #259.
I include my previous [comment]#259 (comment)