Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port sale_quick_payment to v8, change repo #239

Merged
merged 35 commits into from
Mar 11, 2016

Conversation

lepistone
Copy link
Member

Supersedes OCA/e-commerce#54. See OCA/e-commerce#47 for a discussion about the move of a few modules from e-commerce to sale-workflow.

sebastienbeau and others added 30 commits December 1, 2015 10:17
…xceptions (better to manage exception), change payment_id to payment_ids, add migration script
…he base and sale_quick_payment adds a wizard to pay a sale order
…paid, link the payment with the sale order, and improve the payment view
this information is available via a button added by sale_payment_method
@lepistone
Copy link
Member Author

Independently of the repo change, I'm fixing a bug where a few spurious move lines are created.

@lepistone lepistone changed the title port sale_payment_workflow to v8, change repo port sale__quick_payment to v8, change repo Dec 1, 2015
@lepistone lepistone changed the title port sale__quick_payment to v8, change repo port sale_quick_payment to v8, change repo Dec 1, 2015
@lepistone
Copy link
Member Author

Actually I was referring to a bug in another bug and another PR ( OCA/e-commerce#55 ). The red build is because this needed the migration of sale_payment_method to sale-workflow which is now merged. I restarted the failing travis builds. Thanks for the reviews!

@laetitia-gangloff
Copy link

👍 functionnal test ok

Bug Tracker
===========

Bugs are tracked on `GitHub Issues <https://github.com/OCA/e-commerce}/issues>`_.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should update repository.
And remove the '}'

@lepistone
Copy link
Member Author

Thanks for the review @laetitia-gangloff. I addressed your remarks.

@adrienpeiffer
Copy link

👍 Functionnal test and code review

@sebastienbeau
Copy link
Member

Ok for me too 👍

sebastienbeau added a commit that referenced this pull request Mar 11, 2016
port sale_quick_payment to v8, change repo
@sebastienbeau sebastienbeau merged commit 884561f into OCA:8.0 Mar 11, 2016
BT-dherreros pushed a commit to BT-dherreros/sale-workflow that referenced this pull request Apr 29, 2019
Syncing from upstream OCA/sale-workflow (12.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants