add autopay option on sale automatic workflow #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| _logger.debug('Sale Orders to automatically pay: %s', sales) | ||
| for sale in sales: | ||
| with commit(self.env.cr): | ||
| sale.automatic_payment() |
There was a problem hiding this comment.
Are you relaying in any other module for this function?
There was a problem hiding this comment.
it is defined in sale_payment_method
gurneyalex
force-pushed
the
8.0-autopay-workflow
branch
from
ca01fcb
to
342896f
Compare
|
Sounds good 👍 |
gurneyalex
force-pushed
the
8.0-autopay-workflow
branch
3 times, most recently
from
cc95b90
to
27ae398
Compare
|
added some tests too. |
gurneyalex
force-pushed
the
8.0-autopay-workflow
branch
2 times, most recently
from
976c822
to
cfee847
Compare
|
👍 |
|
Looks good 👍 |
gurneyalex
force-pushed
the
8.0-autopay-workflow
branch
from
cfee847
to
39d24fb
Compare
|
|
||
| @api.model | ||
| def _get_domain_for_sale_autopayment(self): | ||
| return [('state', '=', 'draft'), |
There was a problem hiding this comment.
It is intentional that this will not get open orders? Do you think this could interfere with the workflow that confirms orders in sale_automatic_workflow?
|
Neat! This is significant enough to bump the module version. |
|
Hi @gurneyalex do you think you could make a PR moving this module to https://github.com/OCA/sale-workflow as discussed here #47 |
This was referenced Nov 26, 2015
Closed
This was referenced Dec 1, 2015
|
Ok, I moved this to OCA/sale-workflow#243. Please continue reviewing there. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.