Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][MIG] base_vat_sanitized #552

Merged
merged 5 commits into from
Jan 30, 2018
Merged

[11.0][MIG] base_vat_sanitized #552

merged 5 commits into from
Jan 30, 2018

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Jan 22, 2018

No description provided.

@astirpe astirpe mentioned this pull request Jan 22, 2018
53 tasks
@pedrobaeza pedrobaeza added this to the 11.0 milestone Jan 22, 2018
@pedrobaeza
Copy link
Member

Please squash together adjacent "OCA Transbot..." commits

@astirpe
Copy link
Member Author

astirpe commented Jan 23, 2018

Squashed!

@feketemihai
Copy link
Member

@astirpe Isn't it easier to update the default methods from Odoo, please see
https://github.com/odoo/odoo/blob/11.0/addons/base_vat/models/res_partner.py#L106
i agree that this one is only for Europe group and i don't thing is working since on europe it will fetch datas from Vies, i checked for Romania and didn't upper the country code...but i think it's easier and we will not need another field for sanitized_vat...

@astirpe
Copy link
Member Author

astirpe commented Jan 24, 2018

@feketemihai this module is required by other modules (like base_business_document_import). I think that the reason why this module was created was to provide an alternative method to the one you mentioned. I guess the choice to keep it detached from the standard Odoo was made on purpose.
But I would turn your question to @alexis-via who is the author of this module and of the other modules that need this one.

Copy link

@njeudy njeudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok code review + tests

@astirpe
Copy link
Member Author

astirpe commented Jan 30, 2018

@feketemihai is it ok for you to merge? Other pending PRs require this one.

@feketemihai
Copy link
Member

@astirpe Yes no problem, it was just a question if we can use vat field, not vat_sanitized.

@pedrobaeza pedrobaeza merged commit 58f0cfb into OCA:11.0 Jan 30, 2018
@astirpe astirpe deleted the 11_mig_base_vat_sanitized branch January 30, 2018 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants