Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0][MIG] base_ubl_payment #45

Merged
merged 7 commits into from
Jul 5, 2018
Merged

[11.0][MIG] base_ubl_payment #45

merged 7 commits into from
Jul 5, 2018

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Feb 6, 2018 •
edited by pedrobaeza
Loading

@astirpe astirpe mentioned this pull request Feb 6, 2018
Closed
27 tasks
@pedrobaeza pedrobaeza added this to the 11.0 milestone Feb 6, 2018
@astirpe astirpe mentioned this pull request Feb 21, 2018
Merged
3 tasks
@coveralls
Copy link

coveralls commented Feb 21, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.4%) to 35.538% when pulling c7802ff on onesteinbv:11_mig_base_ubl_payment into 5d31030 on OCA:11.0.

@alexis-via
Copy link
Contributor

@astirpe @njeudy As I you, I don't work in v11, but I don't want to block the port to v11. So I added you commit rights on this repo so that you can review/merge the work you are doing to port OCA/edi to v11.

@astirpe
Copy link
Member Author

astirpe commented Jul 4, 2018

@alexis-via thank you very much! I will work on it the following days.

@pedrobaeza
Copy link
Member

Please remove later commit and rebase.

@pedrobaeza pedrobaeza requested a review from cubells July 4, 2018 23:19
alexis-via and others added 7 commits July 5, 2018 08:00
@alexis-via @astirpe
Add modules account_invoice_ubl + base_ubl_payment
68dad08
@alexis-via @astirpe
Add support for UBL 2.0 (required for e-fff)
6d920ef
@astirpe
8.0 Add support for partner bank matching on invoice update (#6)
7118d7a 
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
@alexis-via @astirpe
Prepare v10 branch
e433f2a 
Rename __openerp__.py to __manifest__.py and set installable to False
@alexis-via @astirpe
Port base_business_document_import* to v10
7e02ec3 
Also port all the modules that generate the XML documents: account_invoice_ubl, account_invoice_zugferd, purchase_order_ubl and sale_order_ubl
@alexis-via @astirpe
Improve + modularize generation of UBL (up-port from v8 PR)
abffb41 
Add script mass_invoice_import.py
Code cleanup
@astirpe
[11.0][MIG] base_ubl_payment to V11
c7802ff
@astirpe
Copy link
Member Author

astirpe commented Jul 5, 2018

@pedrobaeza done!

cubells
cubells reviewed Jul 5, 2018
View reviewed changes
Copy link
Sponsor Member

@cubells cubells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is not translation files. Are they generated automatically or you must add that files for spanish i.e.?

cubells
cubells suggested changes Jul 5, 2018
View reviewed changes
base_ubl_payment/README.rst
------------

* Alexis de Lattre <alexis.delattre@akretion.com>

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must add you as a contributor.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cubells I already did it in the CONTRIBUTORS.rst file, so the readme will be automatically fixed. Is it ok with that? This way I will save another commit and push 😄

cubells
cubells approved these changes Jul 5, 2018
View reviewed changes
Copy link
Sponsor Member

@cubells cubells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
LGTM

@pedrobaeza pedrobaeza merged commit 1504fd4 into OCA:11.0 Jul 5, 2018
@astirpe astirpe deleted the 11_mig_base_ubl_payment branch July 5, 2018 16:17
thienvh332 pushed a commit to thienvh332/edi that referenced this pull request Dec 19, 2023
@OCA-git-bot
Merge PR OCA#45 into 16.0
0c1473f 
Signed-off-by simahawk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cubells cubells cubells approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@astirpe @coveralls @alexis-via @pedrobaeza @cubells