[11.0][MIG] base_ubl: port to V11 #43

astirpe · 2018-02-01T09:17:05Z

Depends on

base_vat_sanitized - [11.0][MIG] base_vat_sanitized partner-contact#552
product_uom_unece - [11.0][MIG] product_uom_unece: port to V11 community-data-files#35
account_tax_unece - [11.0][MIG] account_tax_unece community-data-files#34

coveralls · 2018-02-02T18:31:18Z

Coverage decreased (-17.8%) to 35.897% when pulling 246fe53 on onesteinbv:11_mig_base_ubl into a00499f on OCA:11.0.

Adapt module account_invoice_import_ubl to use the new base_ubl module Small fixes

Better generation of address block in UBL (make it coherent with the datamodel of Odoo) Add generation of several UBL blocks: language, delivery, payment terms, customer party, spplier party Add parsing of zip in UBL party (will be used in the future for delivery partner match)

Use country code and state code to match partners UBL: Add delivery terms and line item UBL XML block generation UBL: add parsing of delivery block

Add unitests in base_business_document_import Small code enhancements/simplifications

Rename key 'quantity' to 'qty' in all parsing dicts['lines'] Add common methods compare_lines() and post_create_or_update() Make sure price_unit is always untaxed in UBL XML files

Add button "Update from File" on supplier invoice form Use float_round() instead of round()

…ation of UBL XSD files)

…cause only the first one is accepted by Chorus Factures for example.

Add UBL methods to generate some tax blocks

Print numbers with the approriate number of digits in the XML

'text/xml'

PEP8 fix

Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)

[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method

Rename __openerp__.py to __manifest__.py and set installable to False

Also port all the modules that generate the XML documents: account_invoice_ubl, account_invoice_zugferd, purchase_order_ubl and sale_order_ubl

Rename account_invoice_import_zugferd to account_invoice_import_factur-x Add module to support py3o reporting engine:

To avoid headaches with invalid files, now check XSD of XML invoices before parsing it upon import Move Factur-X/zugferd xsd to base_zugferd

Add script mass_invoice_import.py Code cleanup

cubells

Ready to approve. Minor changes.

cubells · 2018-07-04T10:26:33Z

base_ubl/README.rst

+Base UBL
+========
+
+This is the base module for the implementation of the `Universal Business Language (UBL) <http://ubl.xml.org/>`_ standard.  The UBL standard became the `ISO/IEC 19845 <http://www.iso.org/iso/catalogue_detail.htm?csnumber=66370>`_ standard in January 2016 (cf the `official announce <http://www.prweb.com/releases/2016/01/prweb13186919.htm>_`).


Too large.
Change to:

This is the base module for the implementation of the `Universal Business Language (UBL) <http://ubl.xml.org/>`_ standard. The UBL standard became the `ISO/IEC 19845 <http://www.iso.org/iso/catalogue_detail.htm?csnumber=66370>`_ standard in January 2016 (cf the `official announce <http://www.prweb.com/releases/2016/01/prweb13186919.htm>_`).

cubells · 2018-07-04T10:28:16Z

base_ubl/README.rst

+Base UBL
+========
+
+This is the base module for the implementation of the `Universal Business Language (UBL) <http://ubl.xml.org/>`_ standard.  The UBL standard became the `ISO/IEC 19845 <http://www.iso.org/iso/catalogue_detail.htm?csnumber=66370>`_ standard in January 2016 (cf the `official announce <http://www.prweb.com/releases/2016/01/prweb13186919.htm>_`).


Last link must have char _ after char ` to convert to link.
So correct is:

This is the base module for the implementation of the `Universal Business Language (UBL) <http://ubl.xml.org/>`_ standard. The UBL standard became the `ISO/IEC 19845 <http://www.iso.org/iso/catalogue_detail.htm?csnumber=66370>`_ standard in January 2016 (cf the `official announce <http://www.prweb.com/releases/2016/01/prweb13186919.htm>`_).

cubells · 2018-07-04T10:28:46Z

base_ubl/README.rst

+
+This is the base module for the implementation of the `Universal Business Language (UBL) <http://ubl.xml.org/>`_ standard.  The UBL standard became the `ISO/IEC 19845 <http://www.iso.org/iso/catalogue_detail.htm?csnumber=66370>`_ standard in January 2016 (cf the `official announce <http://www.prweb.com/releases/2016/01/prweb13186919.htm>_`).
+
+This module contains methods to generate and parse UBL files. This module doesn't do anything useful by itself, but it is used by several other modules:


Too large:

change to:

This module contains methods to generate and parse UBL files. This module doesn't do anything useful by itself, but it is used by several other modules:

cubells · 2018-07-04T10:29:40Z

base_ubl/README.rst

+------------
+
+* Alexis de Lattre <alexis.delattre@akretion.com>
+* Andrea Stirpe <a.stirpe@onestein.nl>


You must add yourself as a contributor.

I'm the second one 😸

cubells · 2018-07-04T13:21:38Z

base_ubl/models/ubl.py

+
+from odoo import models, api, tools, _
+from odoo.exceptions import UserError
+from odoo.tools import float_is_zero, float_round


Remove tools from first import and add here file_open to avoid import tools twice.

astirpe · 2018-07-04T14:49:19Z

@cubells thank you!

cubells

👍

LGTM

Code review.

Signed-off-by simahawk

astirpe mentioned this pull request Feb 1, 2018

Migration to version 11.0 #29

Closed

27 tasks

pedrobaeza added this to the 11.0 milestone Feb 1, 2018

This was referenced Feb 6, 2018

[11.0][MIG] base_ubl_payment #45

Merged

[11.0][MIG] account_invoice_ubl #46

Merged

[11.0][MIG] sale_order_ubl #47

Merged

[11.0][MIG] purchase_order_ubl #48

Merged

astirpe mentioned this pull request Feb 14, 2018

[11.0][MIG] account_invoice_import_ubl #49

Merged

2 tasks

alexis-via and others added 22 commits February 22, 2018 14:52

Add module base_ubl (common methods to generate and parse UBL files)

d9a405a

Adapt module account_invoice_import_ubl to use the new base_ubl module Small fixes

Add matching of delivery partner

95c51f5

Use country code and state code to match partners UBL: Add delivery terms and line item UBL XML block generation UBL: add parsing of delivery block

Add module base_phone_business_document_import

2479ed6

Add unitests in base_business_document_import Small code enhancements/simplifications

Add module base_business_document_import_stock

5aa44d4

Rename key 'quantity' to 'qty' in all parsing dicts['lines'] Add common methods compare_lines() and post_create_or_update() Make sure price_unit is always untaxed in UBL XML files

Update invoice lines on "Update Existing" invoice import

21c33f2

Add button "Update from File" on supplier invoice form Use float_round() instead of round()

Add UBL 2.1 XSD files (can be used by all UBL modules ; avoids duplic…

0154dac

…ation of UBL XSD files)

Use StreetName/AdditionalStreetName instead of AddressLine blocks, be…

6f11d0f

…cause only the first one is accepted by Chorus Factures for example.

Update UBL methods to generate lines

770e9d8

Add UBL methods to generate some tax blocks

Add partner identification hook in UBL XML party block generation

9cb4210

Print numbers with the approriate number of digits in the XML

Use vat_sanitiezd in base_ubl

3d68aae

Add support for UBL 2.0 (required for e-fff)

cb4a65d

[IMP] handle the case where the xml file is generated with mime type

a7b0c6f

'text/xml'

Add support for extraction + matching on website

4857158

PEP8 fix

8.0 Add support for partner bank matching on invoice update (#6)

dc05120

Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)

8.0 Use try/except when importing external libs (#8)

fe5ea6f

[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method

OCA Transbot updated translations from Transifex

56fe3da

Prepare v10 branch

0a5d0c8

Rename __openerp__.py to __manifest__.py and set installable to False

Port base_business_document_import* to v10

292b766

Also port all the modules that generate the XML documents: account_invoice_ubl, account_invoice_zugferd, purchase_order_ubl and sale_order_ubl

Rename account_invoice_zugferd to account_invoice_factur-x

1960793

Rename account_invoice_import_zugferd to account_invoice_import_factur-x Add module to support py3o reporting engine:

Add support for allowance and charges on Factur-X invoice import

2464fdd

To avoid headaches with invalid files, now check XSD of XML invoices before parsing it upon import Move Factur-X/zugferd xsd to base_zugferd

Improve + modularize generation of UBL (up-port from v8 PR)

d078619

Add script mass_invoice_import.py Code cleanup

FIX tax amount in UBL

2ac0cb2

pedrobaeza added the needs review label Jul 2, 2018

pedrobaeza requested a review from cubells July 2, 2018 15:10

cubells suggested changes Jul 4, 2018

View reviewed changes

cubells approved these changes Jul 4, 2018

View reviewed changes

[11.0][MIG] base_ubl: porting to V11

246fe53

pedrobaeza approved these changes Jul 4, 2018

View reviewed changes

pedrobaeza merged commit 54f6e23 into OCA:11.0 Jul 4, 2018

astirpe deleted the 11_mig_base_ubl branch July 5, 2018 05:13

thienvh332 pushed a commit to thienvh332/edi that referenced this pull request Dec 19, 2023

Merge PR OCA#43 into 16.0

21e191d

Signed-off-by simahawk

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[11.0][MIG] base_ubl: port to V11 #43

[11.0][MIG] base_ubl: port to V11 #43

astirpe commented Feb 1, 2018 •

edited

Loading

coveralls commented Feb 2, 2018 •

edited

Loading

cubells left a comment •

edited

Loading

cubells Jul 4, 2018

cubells Jul 4, 2018

cubells Jul 4, 2018

cubells Jul 4, 2018

astirpe Jul 4, 2018

cubells Jul 4, 2018

astirpe commented Jul 4, 2018

cubells left a comment


		This is the base module for the implementation of the `Universal Business Language (UBL) <http://ubl.xml.org/>`_ standard. The UBL standard became the `ISO/IEC 19845 <http://www.iso.org/iso/catalogue_detail.htm?csnumber=66370>`_ standard in January 2016 (cf the `official announce <http://www.prweb.com/releases/2016/01/prweb13186919.htm>_`).

		This module contains methods to generate and parse UBL files. This module doesn't do anything useful by itself, but it is used by several other modules:

[11.0][MIG] base_ubl: port to V11 #43

[11.0][MIG] base_ubl: port to V11 #43

Conversation

astirpe commented Feb 1, 2018 • edited Loading

coveralls commented Feb 2, 2018 • edited Loading

cubells left a comment • edited Loading

Choose a reason for hiding this comment

cubells Jul 4, 2018

Choose a reason for hiding this comment

cubells Jul 4, 2018

Choose a reason for hiding this comment

cubells Jul 4, 2018

Choose a reason for hiding this comment

cubells Jul 4, 2018

Choose a reason for hiding this comment

astirpe Jul 4, 2018

Choose a reason for hiding this comment

cubells Jul 4, 2018

Choose a reason for hiding this comment

astirpe commented Jul 4, 2018

cubells left a comment

Choose a reason for hiding this comment

astirpe commented Feb 1, 2018 •

edited

Loading

coveralls commented Feb 2, 2018 •

edited

Loading

cubells left a comment •

edited

Loading