-
-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0][MIG] base_ubl: port to V11 #43
Conversation
Adapt module account_invoice_import_ubl to use the new base_ubl module Small fixes
Better generation of address block in UBL (make it coherent with the datamodel of Odoo) Add generation of several UBL blocks: language, delivery, payment terms, customer party, spplier party Add parsing of zip in UBL party (will be used in the future for delivery partner match)
Use country code and state code to match partners UBL: Add delivery terms and line item UBL XML block generation UBL: add parsing of delivery block
Add unitests in base_business_document_import Small code enhancements/simplifications
Rename key 'quantity' to 'qty' in all parsing dicts['lines'] Add common methods compare_lines() and post_create_or_update() Make sure price_unit is always untaxed in UBL XML files
Add button "Update from File" on supplier invoice form Use float_round() instead of round()
…ation of UBL XSD files)
…cause only the first one is accepted by Chorus Factures for example.
Add UBL methods to generate some tax blocks
Print numbers with the approriate number of digits in the XML
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method
Rename __openerp__.py to __manifest__.py and set installable to False
Also port all the modules that generate the XML documents: account_invoice_ubl, account_invoice_zugferd, purchase_order_ubl and sale_order_ubl
Rename account_invoice_import_zugferd to account_invoice_import_factur-x Add module to support py3o reporting engine:
To avoid headaches with invalid files, now check XSD of XML invoices before parsing it upon import Move Factur-X/zugferd xsd to base_zugferd
Add script mass_invoice_import.py Code cleanup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to approve. Minor changes.
base_ubl/README.rst
Outdated
Base UBL | ||
======== | ||
|
||
This is the base module for the implementation of the `Universal Business Language (UBL) <http://ubl.xml.org/>`_ standard. The UBL standard became the `ISO/IEC 19845 <http://www.iso.org/iso/catalogue_detail.htm?csnumber=66370>`_ standard in January 2016 (cf the `official announce <http://www.prweb.com/releases/2016/01/prweb13186919.htm>_`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too large.
Change to:
This is the base module for the implementation of the `Universal Business
Language (UBL) <http://ubl.xml.org/>`_ standard. The UBL standard became the
`ISO/IEC 19845 <http://www.iso.org/iso/catalogue_detail.htm?csnumber=66370>`_
standard in January 2016 (cf the `official announce
<http://www.prweb.com/releases/2016/01/prweb13186919.htm>_`).
base_ubl/README.rst
Outdated
Base UBL | ||
======== | ||
|
||
This is the base module for the implementation of the `Universal Business Language (UBL) <http://ubl.xml.org/>`_ standard. The UBL standard became the `ISO/IEC 19845 <http://www.iso.org/iso/catalogue_detail.htm?csnumber=66370>`_ standard in January 2016 (cf the `official announce <http://www.prweb.com/releases/2016/01/prweb13186919.htm>_`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last link must have char _
after char ` to convert to link.
So correct is:
This is the base module for the implementation of the `Universal Business
Language (UBL) <http://ubl.xml.org/>`_ standard. The UBL standard became the
`ISO/IEC 19845 <http://www.iso.org/iso/catalogue_detail.htm?csnumber=66370>`_
standard in January 2016 (cf the `official announce
<http://www.prweb.com/releases/2016/01/prweb13186919.htm>`_).
base_ubl/README.rst
Outdated
|
||
This is the base module for the implementation of the `Universal Business Language (UBL) <http://ubl.xml.org/>`_ standard. The UBL standard became the `ISO/IEC 19845 <http://www.iso.org/iso/catalogue_detail.htm?csnumber=66370>`_ standard in January 2016 (cf the `official announce <http://www.prweb.com/releases/2016/01/prweb13186919.htm>_`). | ||
|
||
This module contains methods to generate and parse UBL files. This module doesn't do anything useful by itself, but it is used by several other modules: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too large:
change to:
This module contains methods to generate and parse UBL files. This module
doesn't do anything useful by itself, but it is used by several other modules:
------------ | ||
|
||
* Alexis de Lattre <alexis.delattre@akretion.com> | ||
* Andrea Stirpe <a.stirpe@onestein.nl> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You must add yourself as a contributor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm the second one 😸
base_ubl/models/ubl.py
Outdated
|
||
from odoo import models, api, tools, _ | ||
from odoo.exceptions import UserError | ||
from odoo.tools import float_is_zero, float_round |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove tools
from first import
and add here file_open
to avoid import tools
twice.
@cubells thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
LGTM
Code review.
Depends on