Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] account_invoice_import_facturae (11.0) #63

Closed

Conversation

etobella
Copy link
Member

Account Invoice Import Facturae

This module allows to import facturae invoices into odoo.

Facturae is the standard invoice syntaxis in Spain and
it is required to use this format for B2G invoices. Although the creation and
sending is managed in oca/l10n-spain, this module allows to import supplier
invoices into your system.

@pedrobaeza
Copy link
Member

This maybe should be in OCA/l10n-spain, not here. What do you think, @alexis-via ?

@etobella
Copy link
Member Author

I had the same though, but I putted the module here because ZUGFeRD invoices are from germany and all the modules are managed here (in v10.0).

@pedrobaeza
Copy link
Member

Well, ZUGFeRD is a more open standard, that is also used for France. That's why is hosted here.

'ds:Signature', namespaces={'ds': xmlsig.constants.DSigNs}
)
if sign is None:
raise ValidationError(_('Signature node cannot be found'))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be possible to import unsigned invoices?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be possible, but the signature is important, because it certifies that the invoice is not modified.
We could do if sign is not None: xmlsig.SignatureContext().verify(sign)
It is ok?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is ok. I tried and it worked for both, signed and unsigned

@AaronHForgeFlow
Copy link

It is working fine when I select the following invoice.import.config:

image

However it's failing if I select a different configuration because when no account is set in the invoice.import.config then the account_id field is None and that triggers an error. Also the journal id is null. Maybe that should be fixed here: #41 Anyway a default account should be set in any case, shouldn't it?

@etobella
Copy link
Member Author

The problem could be related to the invoice you are using. Today, I made a PR OCA/l10n-spain#865 that allows to export the invoices in facturae format with the ArticleCode informed.

@AaronHForgeFlow
Copy link

@etobella exporting the file is fine. The output file seems well formatted. However still having issue with the account_invoice_import module not with this one. This one seems ok.

@etobella etobella force-pushed the 11.0-add-account_invoice_import_facturae branch from 6dd5429 to 85be641 Compare October 29, 2018 19:57
Copy link

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Imported complex invoices successfully! Thanks.

@pedrobaeza
Copy link
Member

I still insists in my comment before merging #63 (comment)

@etobella
Copy link
Member Author

If you think that it should go to l10n-spain I can move it. I was waiting for the comment of @alexis-via in order to decide.

@alexis-via
Copy link
Contributor

Thanks for this great work! I'm very glad that other people are building modules above account_invoice_import and other OCA/edi modules.
About the exact location of this module, my opinion is similar to Pedro's point of view: as this facturae format seems to be only for spain and is not based on international standards (such as UBL and CII), OCA/l10n-spain seems the best choice.

@etobella
Copy link
Member Author

Great, Module has been moved. You can find the PR on OCA/l10n-spain#941

@etobella etobella closed this Oct 30, 2018
@pedrobaeza pedrobaeza added this to the 11.0 milestone Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants