Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Fleet Inspection Report #16

Closed
12 tasks done
brian10048 opened this issue Oct 19, 2020 · 12 comments
Closed
12 tasks done

[RFC] Fleet Inspection Report #16

brian10048 opened this issue Oct 19, 2020 · 12 comments

Comments

@brian10048
Copy link

brian10048 commented Oct 19, 2020

Background

Some companies are required to complete inspection reports to ensure the ongoing safe operation of fleet vehicles. Typically these are performed every day prior to using a vehicle. Also known as Pre-Trip Inspection or Daily Vehicle Inspection Report (DVIR)

For example, common inspection points might include:

  • Lights
  • Mirrors
  • Tires
  • Windows

Since all organizations may have different requirements, a configurable list of inspection points (fleet.inspection.item) will be made available.

Technical Specifications

  • fleet.inspection - New Model
    • vehicle_id many2one to fleet.vehicle
    • vehicle_odometer float
    • date_inspected
    • inspected_by many2one to internal user
    • inspection_line_ids one2many to fleet.inspection.line
    • note char
  • fleet.inspection.line - New Model
    • inspection_item_id many2one to fleet.inspection.item
    • result boolean
  • fleet.inspection.item - New Model
    • name text
@marcelsavegnago
Copy link
Member

marcelsavegnago commented Oct 20, 2020

@brian10048 fleet.vehicle.inspection.note can it be an html field? (I think it’s easier to write a problem report) or do I create a new field to further detail the problems?

@marcelsavegnago
Copy link
Member

@brian10048 I am also interested in adding photographs of the inspection and associating it with the inspection lines .. simple form. What do you think ?

@marcelsavegnago
Copy link
Member

@brian10048 We can include in the roadmap the implementation of inspection templates that can be associated with vehicle models and include as a suggestion in the inspection form.

@brian10048
Copy link
Author

@marcelsavegnago

I am OK with the HTML field

Photos would be an awesome addition. Also, I was thinking about the inspection lines more, and I wonder if we make each inspection line have a Pass and Fail button? Instead of just a checkbox for result, we can make the user choose to either pass or fail an individual inspection item. And later on, maybe an action that is triggered upon a failure.

Yes, I had thought about specific templates for specific models, or maybe even tags. This would be great

I also think we should add a smart button on the Vehicle form to go to that vehicle's inspections

@marcelsavegnago
Copy link
Member

@marcelsavegnago

I am OK with the HTML field

Ok

Photos would be an awesome addition. Also, I was thinking about the inspection lines more, and I wonder if we make each inspection line have a Pass and Fail button? Instead of just a checkbox for result, we can make the user choose to either pass or fail an individual inspection item. And later on, maybe an action that is triggered upon a failure.

I liked the idea. I will make the other adjustments that we mentioned and if I can, I will see this issue today.

Yes, I had thought about specific templates for specific models, or maybe even tags. This would be great

Perfect.

I also think we should add a smart button on the Vehicle form to go to that vehicle's inspections

Yes, I will include the button now.

@mamcode
Copy link
Member

mamcode commented Oct 21, 2020

Hello @brian10048 @marcelsavegnago I see this module very useful, I can give a hand with technical review when the PR is ready for review. Thanks.

@marcelsavegnago
Copy link
Member

@brian10048 ready to review. Photographs and templates are not included but are on the roadmap file.

@marcelsavegnago
Copy link
Member

marcelsavegnago commented Oct 21, 2020

Tests and demo data included

@marcelsavegnago
Copy link
Member

marcelsavegnago commented Oct 25, 2020

@brian10048 and @mamcode Do you know if the synchronization of the repository with the OCA app store is OK?

image

@brian10048
Copy link
Author

@brian10048 and @mamcode Do you know if the synchronization of the repository with the OCA app store is OK?

image

@marcelsavegnago I'm not sure

@sbidoul can probably answer questions about the OCA app store synchronization

@sbidoul
Copy link
Member

sbidoul commented Oct 25, 2020

@brian10048 The failing appstore sync is probably due the the bad development_status keys in manifests in this repo, such as

"development_status": "Stable",
that should be Production/Stable instead.

There will soon be a pylint-odoo check for that.

@marcelsavegnago
Copy link
Member

marcelsavegnago commented Feb 16, 2021

@brian10048 #24 (inspection template)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants