[14.0] fleet_vehicle_service_kanban: state or stage_id

[marcelsavegnago]

@ivantodorovich In version 14.0, the state field was created in the fleet.vehicle.log.services data model. Do you think it makes more sense to use this field instead of the stage_id field implemented by the fleet_vehicle_service_kanban module?

https://github.com/odoo/odoo/blob/660a0cd8ad207ea53f3f62158b3849bbe2696eec/addons/fleet/models/fleet_vehicle_cost.py#L152

fleet/fleet_vehicle_service_kanban/models/fleet_vehicle_log_services.py

Line 19 in ed26f24

stage_id = fields.Many2one(

Migration PR: #35

[marcelsavegnago]

We can even continue with both fields. However, it can be a little redundant.
In addition, if we keep both fields, we need to define what the service status bar should look like.

[marcelsavegnago]

In that case, we can consider dividing this module and generating other modules such as fleet_vehicle_service_tags.

[mamcode]

Thanks for open this issue @marcelsavegnago I think that the field stage_id should not be removed, but it should be removed from the statusbar, perhaps an option can be to add stage_id as one field in the form view. In any case, let's wait for the opinion of @ivantodorovich who has a better functional knowledge of this module with some clients.

[marcelsavegnago]

@mamcode what do you thing?

cc @ivantodorovich

[mamcode]

@mamcode what do you thing?

cc @ivantodorovich

I see it fine but how can the user change the stage? Is it editable in form ?

[marcelsavegnago]

I did not leave it editable in the form but I agree that it is necessary.

[ivantodorovich]

Hello !

I agree it should be editable :)
The badge looks good but it may be confusing. What about a regular m2o field? That way we get the label, which might be easier for the user to understand

I haven't really analyzed the core module in 14.0 yet, it's possible our customer requirement may be satisfied with the new core workflow (using state field).

@marcelsavegnago how are you using this module?

[marcelsavegnago]

Hello !

I agree it should be editable :)
The badge looks good but it may be confusing. What about a regular m2o field? That way we get the label, which might be easier for the user to understand

I think it is worth using a regular m2o field.

I haven't really analyzed the core module in 14.0 yet, it's possible our customer requirement may be satisfied with the new core workflow (using state field).

I believe that the state field serves despite the loss and flexibility offered by stage_id.

@marcelsavegnago how are you using this module?

At the moment I am not using it on any client but I was considering using it on a specific project for vehicle fleet management.

[ivantodorovich]

Ok then, I trust your call :) PR looks good to me

[mamcode]

@ivantodorovich @marcelsavegnago I think that we can close this issue.