Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0] Add hr_recruitment_skill #372

Merged
merged 1 commit into from
Mar 15, 2018

Conversation

leemannd
Copy link
Contributor

@leemannd leemannd commented Oct 3, 2017

Add the possibility to add skill for recruitment

Depends on #300 #378

@leemannd leemannd force-pushed the 10.0-add-hr_recruitment_skill branch from 6ecc2ca to 5ff0d80 Compare October 3, 2017 09:57
@leemannd leemannd changed the title Add hr_recruitment_skill [10.0] Add hr_recruitment_skill Oct 10, 2017
@gurneyalex
Copy link
Member

@leemannd can you rebase this PR now that #378 is merged, so we get a green runbot?

@leemannd leemannd force-pushed the 10.0-add-hr_recruitment_skill branch from 5ff0d80 to 0f353b2 Compare October 16, 2017 07:50
@leemannd leemannd force-pushed the 10.0-add-hr_recruitment_skill branch from 0f353b2 to f34396c Compare October 30, 2017 16:48
.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg
:alt: License: AGPL-3

Employee Skills
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rename the "Employee Skills"--> "Job Skills" or "Applicant Skills" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, or maybe I should follow the technical name of the module with something like "HR recruitment skill'"

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Recruitment Skill" is also good to me.

@leemannd leemannd force-pushed the 10.0-add-hr_recruitment_skill branch from f34396c to 3a8a968 Compare November 6, 2017 08:24
@leemannd
Copy link
Contributor Author

leemannd commented Nov 6, 2017

@Matiar Updated. Is it good for you? Do you have it tested?

Copy link

@Matiar Matiar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @leemannd , LGTM

Copy link
Member

@feketemihai feketemihai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested...

@feketemihai feketemihai added this to the 10.0 milestone Nov 9, 2017

required_skill_ids = fields.Many2many(
'hr.skill',
relation='hr_jobs_required_skills',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about this relation's name? I couldn't find it in the dependencies.

#. module: hr_recruitment_skill
#: model:ir.model,name:hr_recruitment_skill.model_hr_job
msgid "Job Position"
msgstr "Poste Occupé"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In French usually we don't capitalize every word as we do in English

@gurneyalex gurneyalex merged commit 110cbc7 into OCA:10.0 Mar 15, 2018
sambarros pushed a commit to sambarros/hr that referenced this pull request Jul 26, 2018
…ng_orders

[BSSFL-480][IMP] Manufacturing orders. Check if all "LOT" materials are consumed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants