[12.0][MIG] hr_expense_invoice #584

kittiu · 2019-04-23T06:41:02Z

Done Migration

Set supplier invoices on HR expenses ==================================== This module should be used when a supplier invoice is paid by an employee. It allows to set a supplier invoice for each expense line, adding the corresponding journal items to transfer the debt to the employee. Installation ============ Install the module the regular way. Configuration ============= You don't need to configure anything more to use this module. Usage ===== Instead of coding a full expense line, select an existing supplier invoice, and then the rest of the fields will be auto-filled and grayed. When you generate the expenses account entries, lines with invoices filled will be generated as opposite of the payable move line of the invoice, and both will be reconciled, letting the employee payable account as the only open balance. Known issues / Roadmap ====================== * Multiple payment terms for a supplier invoice are not handled correctly. * Partial reconcile supplier invoices are also not correctly handled.

…se view

…l amount (#237) On the same expense, when we have 2 or more lines with different invoices, and each invoices have the same total amount, reconcile is not possible. The fix is to exclude reconcile account.move.line, and the first time if we have more than one line to reconcile on the same amount, we keep the first.

Currently translated at 100.0% (4 of 4 strings) Translation: hr-11.0/hr-11.0-hr_expense_invoice Translate-URL: https://translation.odoo-community.org/projects/hr-11-0/hr-11-0-hr_expense_invoice/de/

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

pedrobaeza · 2019-04-23T09:29:14Z

Please check Travis

kittiu · 2019-04-23T11:21:14Z

Please check Travis

Still WIP.

kittiu · 2019-04-23T11:23:05Z

@pedrobaeza during learning it to migration, I also have some opinion here,
#585

kittiu · 2019-04-24T04:45:45Z

Done. Only part of the code that can not happen in test.

kittiu · 2019-04-24T04:55:10Z

Done. Only part of the code that can not happen in test.

Q: when we face the part of code that can't write test to cover like this, normally, how do we go about?

pedrobaeza · 2019-04-24T07:23:03Z

You have to write use case that triggers that part of code, or let it uncovered with the codecov warning.

kittiu · 2019-04-24T14:26:07Z

You have to write use case that triggers that part of code, or let it uncovered with the codecov warning.

Yah :)

tbaden · 2019-04-26T08:25:26Z

@kittiu ready for review or still wip?

kittiu · 2019-04-26T12:21:21Z

Yes ready. Test is green now.

tbaden

code review: lgtm
just a minor detail, but it's optional

tbaden · 2019-04-26T12:32:51Z

hr_expense_invoice/views/hr_expense_views.xml

+<?xml version="1.0" encoding="utf-8"?>
+<odoo>
+
+    <record id="hr_expense_view_view" model="ir.ui.view">


"ugly" id (view_view)
please use hr_expense_view_form (optional)

Done, thank you.

luistorresm · 2019-05-03T17:16:01Z

hr_expense_invoice/models/hr_expense.py

+
+    invoice_id = fields.Many2one(
+        comodel_name="account.invoice",
+        string='Invoice',


The string param is not necessary on v12 (in this case)

Sorry, but why? invoice_id is a new field for hr.expense also, why no need string='Invoice'

By the way, I also see oldname='invoice'. Do we still need it for migration to v12?
What is it actually used for?

because the string is computed using the field name, so there is any need to explicitly set the string param

@hugho-ad, you mean "invoice_id" will be display as string "Invoice" anyway, right?

Yes @kittiu

Note. But in this case, may I also change it to "Vendor Bill", and it is domain to in_invoice + open status. I think Vendor Bill is also more meaningful. :)

Yes @kittiu

When the label is different, the string parameter is necessary.

luistorresm · 2019-05-03T17:20:35Z

hr_expense_invoice/models/hr_expense.py

+    def _get_account_move_line_values(self):
+        move_line_values_by_expense = super()._get_account_move_line_values()
+        for expense_id, move_lines in move_line_values_by_expense.items():
+            expense = self.browse(expense_id)


Suggested change

expense = self.browse(expense_id)

expense = self.browse(expense_id)

if not expense. invoice_id:

return move_line_values_by_expense

To avoid the next iteration, that is not necessary when the expense does not have an invoice.

With this remove the check expense.invoice_id in the next if

luistorresm · 2019-05-03T17:21:20Z

hr_expense_invoice/models/hr_expense_sheet.py

+    @api.multi
+    def action_sheet_move_create(self):
+        precision = self.env['decimal.precision'].precision_get('Account')
+        expense_line_ids = self.mapped('expense_line_ids').filtered(


Suggested change

expense_line_ids = self.mapped('expense_line_ids').filtered(

expense_line_ids = self.mapped('expense_line_ids').filtered('invoice_id')

kittiu · 2019-05-04T05:06:52Z

We also still have same problem as in v11 according to this issue
#573

hr_expense_invoice/models/hr_expense_sheet.py

luistorresm

Technical Review

OCA-git-bot · 2019-05-10T01:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

kittiu · 2019-05-10T08:19:16Z

@pedrobaeza we will have this issue pending - #573
But it shouldn't affect this PR directly.

Thank you.

ghost

When I try to pay the expense to the employee appears the message:

kittiu · 2019-09-03T14:20:46Z

I think this is related to account type or reconcile flag used in account of advance.

You can try different one?

ghost · 2019-09-10T11:51:13Z

@kittiu I don't understand what you want to say. Can you explain?

ghost · 2019-11-18T15:59:36Z

@kittiu I didn't understand what you wanted to say. Can you explain it better again, please?

kittiu · 2019-11-19T01:05:40Z

@gelo-landoo
We do not have this problem. I think it is about accounting code config.
Or would you send me URL and step to reproduce the problem?

pedrobaeza and others added 13 commits April 23, 2019 13:37

OCA Transbot updated translations from Transifex

0866ef8

[IMP] hr_expense_invoice: Allow to create supplier invoice from expen…

c0ea63e

…se view

OCA Transbot updated translations from Transifex

9f9c598

OCA Transbot updated translations from Transifex

dfe985b

[MIG] hr_expense_invoice: Migration to 10.0

15b9cd6

OCA Transbot updated translations from Transifex

570e09d

[MIG] hr_expense_invoice: Migration to 11.0

8bab3e2

[UPD] Update hr_expense_invoice.pot

7743b2d

Added translation using Weblate (German)

22cecb8

Translated using Weblate (German)

12e68ae

Currently translated at 100.0% (4 of 4 strings) Translation: hr-11.0/hr-11.0-hr_expense_invoice Translate-URL: https://translation.odoo-community.org/projects/hr-11-0/hr-11-0-hr_expense_invoice/de/

Update translation files

3ea0916

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

pedrobaeza added this to the 12.0 milestone Apr 23, 2019

OCA-git-bot mentioned this pull request Apr 23, 2019

Migration to version 12.0 #479

Closed

32 tasks

tbaden approved these changes Apr 26, 2019

View reviewed changes

luistorresm reviewed May 3, 2019

View reviewed changes

luistorresm reviewed May 9, 2019

View reviewed changes

hr_expense_invoice/models/hr_expense_sheet.py Outdated Show resolved Hide resolved

[12.0][MIG] hr_expense_invoice

c05fade

luistorresm approved these changes May 10, 2019

View reviewed changes

OCA-git-bot added approved ready to merge labels May 10, 2019

pedrobaeza merged commit 8729ad2 into OCA:12.0 May 10, 2019

ghost reviewed Sep 3, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12.0][MIG] hr_expense_invoice #584

[12.0][MIG] hr_expense_invoice #584

kittiu commented Apr 23, 2019 •

edited

Loading

pedrobaeza commented Apr 23, 2019

kittiu commented Apr 23, 2019

kittiu commented Apr 23, 2019

kittiu commented Apr 24, 2019

kittiu commented Apr 24, 2019

pedrobaeza commented Apr 24, 2019

kittiu commented Apr 24, 2019

tbaden commented Apr 26, 2019

kittiu commented Apr 26, 2019

tbaden left a comment

tbaden Apr 26, 2019

kittiu May 2, 2019

luistorresm May 3, 2019

kittiu May 4, 2019 •

edited

Loading

kittiu May 4, 2019

hugho-ad May 4, 2019

kittiu May 5, 2019

luistorresm May 5, 2019

kittiu May 6, 2019

luistorresm May 7, 2019

luistorresm May 3, 2019

kittiu May 4, 2019

luistorresm May 3, 2019

kittiu May 4, 2019

kittiu commented May 4, 2019 •

edited

Loading

luistorresm left a comment

OCA-git-bot commented May 10, 2019

kittiu commented May 10, 2019

ghost left a comment

kittiu commented Sep 3, 2019 •

edited

Loading

ghost commented Sep 10, 2019

ghost commented Nov 18, 2019

kittiu commented Nov 19, 2019

	expense_line_ids = self.mapped('expense_line_ids').filtered(
	expense_line_ids = self.mapped('expense_line_ids').filtered('invoice_id')

[12.0][MIG] hr_expense_invoice #584

[12.0][MIG] hr_expense_invoice #584

Conversation

kittiu commented Apr 23, 2019 • edited Loading

pedrobaeza commented Apr 23, 2019

kittiu commented Apr 23, 2019

kittiu commented Apr 23, 2019

kittiu commented Apr 24, 2019

kittiu commented Apr 24, 2019

pedrobaeza commented Apr 24, 2019

kittiu commented Apr 24, 2019

tbaden commented Apr 26, 2019

kittiu commented Apr 26, 2019

tbaden left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kittiu May 4, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kittiu commented May 4, 2019 • edited Loading

luistorresm left a comment

Choose a reason for hiding this comment

OCA-git-bot commented May 10, 2019

kittiu commented May 10, 2019

ghost left a comment

Choose a reason for hiding this comment

kittiu commented Sep 3, 2019 • edited Loading

ghost commented Sep 10, 2019

ghost commented Nov 18, 2019

kittiu commented Nov 19, 2019

kittiu commented Apr 23, 2019 •

edited

Loading

kittiu May 4, 2019 •

edited

Loading

kittiu commented May 4, 2019 •

edited

Loading

kittiu commented Sep 3, 2019 •

edited

Loading