[8.0][FIX] get_hs_code_recursively broken on declaration #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvalyi
approved these changes
Aug 20, 2018
There was a problem hiding this comment.
approved for v8.
However it is important to notice that on v10, the code is still taken from the template:
https://github.com/OCA/intrastat/blob/10.0/intrastat_product/models/account_invoice.py#L68
@luc-demeyer @alexis-via @sebastienbeau so what do you think, should we take it from the variant on v10 too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intrastat declaration is broken in case no hs code is present on invoice lines as a consequence of 33a92dc.