Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] 9.0 intrastat_base #8

Merged
merged 8 commits into from
Jan 11, 2017
Merged

Conversation

thomaspaulb
Copy link

Migrated and added tests.

@oca-clabot
Copy link

Hey @thomaspaulb, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.831% when pulling f118f19 on sunflowerit:9.0-mig-intrastat-base into ac9c8eb on OCA:9.0.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.831% when pulling f118f19 on sunflowerit:9.0-mig-intrastat-base into ac9c8eb on OCA:9.0.

@coveralls
Copy link

coveralls commented Dec 2, 2016

Coverage Status

Coverage remained the same at 89.831% when pulling c0e57a5 on sunflowerit:9.0-mig-intrastat-base into ac9c8eb on OCA:9.0.

Copy link
Member

@hbrunn hbrunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only a few nags

@@ -1,5 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<odoo noupdate="1">
<openerp>
<data noupdate="1">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better leave <odoo>, that's the new standard in 9 too

# You should have received a copy of the GNU Affero General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#
##############################################################################
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use short headers, and update your licence template ;-)


from . import intrastat_base_tests

# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modelines are scorned upon by now

@@ -0,0 +1,31 @@
# -*- coding: utf-8 -*-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is valuable code too and deserves your license

})
# then check if intrastat_email_list contains the email of the user
self.assertEquals(demo_company.intrastat_email_list, demo_user.email)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove empty lines

@@ -1,4 +1,6 @@
# -*- coding: utf-8 -*-
# © 2016 Sunflower IT (http://sunflowerweb.nl).
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was purely added by me, but I don't know what is the policy for that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the policy is if you add something, it's your copyright

@hbrunn hbrunn added this to the 9.0 milestone Dec 6, 2016
@coveralls
Copy link

coveralls commented Dec 7, 2016

Coverage Status

Coverage remained the same at 89.831% when pulling f002abf on sunflowerit:9.0-mig-intrastat-base into ac9c8eb on OCA:9.0.

@alexis-via alexis-via merged commit bd9f0f9 into OCA:9.0 Jan 11, 2017
@oca-clabot
Copy link

Hey @thomaspaulb,
We acknowledge that the following users have signed our Contributor License Agreement:

Appreciation of efforts,
OCA CLAbot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants