-
-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Porting of knowledge to v10 #118
Conversation
Filter on "real"/user documents (no odoo assets), filter on res_model, filter on indexed content.
"depends": ["base_setup"], | ||
"author": "OpenERP SA, Odoo Community Association (OCA)", | ||
"category": "Hidden/Dependency", | ||
"version": "10.0.1.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10.0.1.0.0
"author": "OpenERP SA, Odoo Community Association (OCA)", | ||
"category": "Hidden/Dependency", | ||
"version": "10.0.1.1.0", | ||
"author": "MONK Software, Odoo Community Association (OCA)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LeartS Please keep OpenERP SA
in the author.
# along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
# | ||
############################################################################## | ||
# Copyright 2016 MONK Software |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LeartS Copyrights belong to Tiny SPRL
'Store attachments in an external DMS instead of the Odoo Filestore', | ||
help='Connect Odoo with a CMIS compatible server to store files.\n' | ||
'- This installs the module cmis_write.' | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LeartS Please keep those fields. Even if the modules are not migrated, it gives them visibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe make them readonly until they are ported?
'Store attachments in an external DMS instead of the Odoo Filestore', | ||
help='Connect Odoo with a CMIS compatible server to store files.\n' | ||
'- This installs the module cmis_write.' | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe make them readonly until they are ported?
@@ -1,3 +0,0 @@ | |||
id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink | |||
access_ir_attachment_sale_manager,ir_attachment manager,base.model_ir_attachment,base.group_sale_manager,1,1,1,1 | |||
access_ir_attachment_partner_manager,ir_attachment_partner manager,base.model_ir_attachment,base.group_partner_manager,1,1,1,1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why were ACLs removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because:
- the groups didn't make any sense; why should attachments be restricted to sale managers and partner managers?
- the
base.group_sale_manager
group doesn't exist anymore, it has been moved to thesales_team
module. I don't see why theknowledge
module should depend onsales_team
- attachments already implement a custom logic for permissions: attachments linked to a record (so, all "user" attachments, which are the main focus of this module) can be accessed by the same people who can access the linked record. That logic is much better and in my opinion, sufficient.
[FIX] Copyright and various stuff
@LeartS will you address my comments? |
No description provided.