Migration/l10n br crm

[renatonlima]

No description provided.

[mileo]

@renatonlima are you redoing the work of #124 ?

[rvalyi]

so once this branch with l10n_br_base #129 is passing tests again, it needs to be merged into this one to enable the installation and testing by Travis.

[rvalyi]

So I didn't merge l10n_br base in this branch to avoid possible conflicts when merging globally. Instead here is the test branch where we also have code-metrics: #154

The coverage is lower with the l10n_br_crm module and I think it deserved a dumb lead conversion test before we merge.
Lint results are here: https://travis-ci.org/OCA/l10n-brazil/jobs/66147684
We need them green before considering merge, so 👎 for now.

@mileo. Same as for the l10n_br_base PR. Please if we are missing any good feature you guys did, please cherry pick the commits and rebase them on this branch We will do our best to look at your work before merging anyway. Sorry again for the inconvenience of the double work here, again explained by the very exceptional conditions we had.

[rvalyi]

should be 2011 - TODAY

[rvalyi]

👍
PEP is OK, installation works on the test branch.
We can eventually add a lead conversion test.

[rvalyi]

@mileo I see that in your branch you added the rg on a lead (seems legitimate), you also separated the cpf and cnpj fields. Could you elaborate on why (it's not in the commit message I think)? @renatonlima what do you think about this design? https://github.com/odoo-brazil/l10n-brazil/blob/8.0/l10n_br_crm/crm_lead.py#L42 cc @danimaribeiro

[rvalyi]

OK, so we are now green on tests and PEP-8.
That's sad to decrease the coverage, so that would be cool to add some basic lead conversion test and keep a high coverage.

@mileo we found some design changes you did here like separating the cpf and cnpj fields. Could you please argue why you think it's better than what we have now? @renatonlima didn't seem convinced but may be you'll convince us.

[danimaribeiro]

One is used for the company data, and the other for the contact.
In this case, I think is necessary to have both fields.

Not ok to merge yet.

[danimaribeiro]

It happens an error when converting a lead to an oportunity.

The method signature is different from the crm base class. Adjusting the signature to the following:

It works partially, because now I get the error about "CNPJ invalido":

So definitely we need two different fields, CNPJ and CPF, one is for legal_name and the other for contact_name.

[danimaribeiro]

It's better to get the code from odoo-brazil, with @api.model, the lead conversion to opportunity is working nicely, generating both company and contact with the corresponding CNPJ and CPF.

It would be nice to have the address fields order according to partner and company, but that I can submit a patch after.

[danimaribeiro]

Merged in #165

[rvalyi]

oups that one had to be closed then