Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] fatturapa translation source strings #677

Merged
merged 4 commits into from Nov 29, 2018
Merged

[FIX] fatturapa translation source strings #677

merged 4 commits into from Nov 29, 2018

Conversation

primes2h
Copy link
Contributor

@primes2h primes2h commented Nov 26, 2018 •
edited

This was referenced Nov 26, 2018
Merged
Merged
@primes2h
Copy link
Contributor Author

Please review.

eLBati
eLBati requested changes Nov 26, 2018
View reviewed changes
l10n_it_fatturapa/models/account.py Outdated Show resolved Hide resolved
@primes2h primes2h force-pushed the 10.0-fix-l10n_it_fatturapa-translation_source_strings branch from 085f691 to 580051e Compare November 26, 2018 13:55
SimoRubi
SimoRubi approved these changes Nov 26, 2018
View reviewed changes
Copy link
Member

@SimoRubi SimoRubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
Just a few remarks

l10n_it_fatturapa/models/company.py Outdated Show resolved Hide resolved
l10n_it_fatturapa/models/company.py Outdated Show resolved Hide resolved
l10n_it_fatturapa/models/account.py Outdated Show resolved Hide resolved
l10n_it_fatturapa/models/account.py Outdated Show resolved Hide resolved
@eLBati
Copy link
Member

eLBati commented Nov 26, 2018

@primes2h check travis

@primes2h
Copy link
Contributor Author

@primes2h check travis

It seems to be a conflict with l10n_it_fatturapa_in.
I'm already working on a PR for that module.

@eLBati
Copy link
Member

eLBati commented Nov 27, 2018

@primes2h no, tests of l10n_it_fatturapa_out are failing.

For instance, the test related to file IT06363391001_00001.xml is failing because <Denominazione>Pubblica Amministrazione</Denominazione> != <Denominazione>Public Administration</Denominazione>

@primes2h primes2h force-pushed the 10.0-fix-l10n_it_fatturapa-translation_source_strings branch from 580051e to 332fff2 Compare November 27, 2018 09:01
@primes2h
Copy link
Contributor Author

@primes2h no, tests of l10n_it_fatturapa_out are failing.

For instance, the test related to file IT06363391001_00001.xml is failing because <Denominazione>Pubblica Amministrazione</Denominazione> != <Denominazione>Public Administration</Denominazione>

In fact both l10n_fatturapa_in/out have this kind of issue.

Just opened #678 for l10n_fatturapa_out.

@primes2h primes2h mentioned this pull request Nov 27, 2018
Closed
@primes2h primes2h force-pushed the 10.0-fix-l10n_it_fatturapa-translation_source_strings branch 4 times, most recently from 9d3041a to 0540d90 Compare November 29, 2018 13:44
@eLBati
Copy link
Member

eLBati commented Nov 29, 2018

@primes2h grazie!
Solo una lamentela da travis:
l10n_it_fatturapa/models/account.py:405:78: W291 trailing whitespace

@primes2h primes2h force-pushed the 10.0-fix-l10n_it_fatturapa-translation_source_strings branch from 0540d90 to cb54302 Compare November 29, 2018 16:09
@primes2h
Copy link
Contributor Author

@primes2h grazie!
Solo una lamentela da travis:
l10n_it_fatturapa/models/account.py:405:78: W291 trailing whitespace

Azz, questa me l'ero persa in mezzo alle altre.
Grazie!

@primes2h
Copy link
Contributor Author

Ho rivisto tutti i seguenti moduli:

l10n_it_fatturapa
l10n_it_fatturapa_in
l10n_it_fatturapa_out
l10n_it_fatturapa_out_ddt

Nelle stringhe ho mantenuto la terminologia usata qui nel documento ufficiale in inglese:
https://www.fatturapa.gov.it/export/fatturazione/sdi/Specifiche_tecniche_del_formato_FatturaPA_v1.1_EN.pdf

Per le altre stringhe ho mantenuto lo schema standard Odoo, per esempio usando Invoice/Bill per le fatture e le stringhe standard per i modelli prodotto.

@primes2h primes2h changed the title [FIX] translation source strings [FIX] fatturapa translation source strings Nov 29, 2018
This was referenced Nov 29, 2018
Closed
Merged
@eLBati eLBati mentioned this pull request Nov 29, 2018
Merged
@primes2h
Copy link
Contributor Author

Solo una nota aggiuntiva, ho messo a posto anche tutti i README, aggiungendo in tutti i moduli la sezione "Italiano".

@primes2h
Copy link
Contributor Author

All green! 😋

eLBati
eLBati approved these changes Nov 29, 2018
View reviewed changes
Copy link
Member

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie

@eLBati eLBati merged commit de18fa4 into OCA:10.0 Nov 29, 2018
@primes2h
Copy link
Contributor Author

Uff, guardando il file po generato ho trovato qualche altra stringa da correggere e qualche typo presente nelle moduli originali.
Apro un altra PR.

@primes2h
Copy link
Contributor Author

A meno che non possa aggiungere un commit a questa PR. (?)

@eLBati
Copy link
Member

eLBati commented Nov 30, 2018

@primes2h no, questa ormai è merged. Aprine pure un'altra

This was referenced Dec 1, 2018
Merged
Merged
Merged
Merged
@primes2h primes2h deleted the 10.0-fix-l10n_it_fatturapa-translation_source_strings branch February 3, 2019 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eLBati eLBati eLBati approved these changes

@SimoRubi SimoRubi SimoRubi approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@primes2h @eLBati @SimoRubi @OCA-git-bot