Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0][MIG] l10n_nl_postcodeapi #168

Merged
merged 25 commits into from
Sep 5, 2018
Merged

[11.0][MIG] l10n_nl_postcodeapi #168

merged 25 commits into from
Sep 5, 2018

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Jun 11, 2018 •
edited
Loading

Depends on:

TODO:

Stefan Rijnhart and others added 23 commits June 11, 2018 17:54
@astirpe
[ADD] PostcodeAPI integration
69cd647
@astirpe
[ADD] Inject onchange methods in embedded contacts form
4556344
@astirpe
[RFR] 8.0 conventions
f4d9d85
@astirpe
[RFR] use external pyPostcode package
5732487
@astirpe
[RFR] 8.0 API
75ec0a4
@astirpe
[FIX] Translation syntax error
5716a24 
[DEL] Debug statement
@astirpe
[UPD] OCA infrastructure integration
b1436b8
@astirpe
[RFR] Use pyPostcode from Pypi
6c245a1
@astirpe
[UPD] Version
53d5e98
@astirpe
[FIX] OCA as author
1b51164
@astirpe
[IMP] Use config parameter API
8f812d1
@astirpe
[FIX] Decorators
05c7c39
@astirpe
[FIX] Add country_id for consistency
e9885a0
@sbidoul @astirpe
[UPD] prefix versions with 8.0
f5b2184
@pedrobaeza @astirpe
[MIG] Make modules uninstallable
dc70f07
@pedrobaeza @astirpe
[FIX] l10n_nl_postcodeapi: Fix manifest
14a6b0d
@pedrobaeza @astirpe
[MIG] Rename manifest files
ce12e26
@astirpe
[MIG] Port l10n_nl_postcodeapi to V10 (OCA#54)
425f646
@oca-transbot @astirpe
OCA Transbot updated translations from Transifex
47295ba
@oca-transbot @astirpe
OCA Transbot updated translations from Transifex
b780fbb
@astirpe
Fix issue OCA#85 (Postcodeapi not working)
64ad2ac
@oca-transbot @astirpe
OCA Transbot updated translations from Transifex
52d952d
@ploegvde @astirpe
[ADD] Missing Dutch Translations (OCA#99)
b1e6d08 
* Missing Dutch Translations

* Fix typo
CasVissers-360ERP
CasVissers-360ERP approved these changes Jun 11, 2018
View reviewed changes
Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test successful.

@astirpe astirpe mentioned this pull request Jun 12, 2018
Closed
9 tasks
@astirpe astirpe changed the title [11.0][MIG] l10n nl postcodeapi [11.0][MIG] l10n_nl_postcodeapi Jun 12, 2018
@CasVissers-360ERP
Copy link

A normal user has no permission to read ir.config_parameter resulting in an access right warning. Can we fix this?

@astirpe
Copy link
Member Author

astirpe commented Jun 13, 2018

@CasVissers can you check now?

CasVissers-360ERP
CasVissers-360ERP approved these changes Jun 13, 2018
View reviewed changes
Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@astirpe
Copy link
Member Author

astirpe commented Jun 13, 2018

Coverage will increase after the removal of the temporary workaround.

@CasVissers-360ERP
Copy link

When you reach the max amount of credits per day, or the API key is incorrect. Changes are not saved to the partner form.

@astirpe
Copy link
Member Author

astirpe commented Jun 13, 2018

@CasVissers I see, thank you! I guess it also happens with previous versions.

@astirpe
Copy link
Member Author

astirpe commented Jun 13, 2018

@CasVissers could you try now?

@astirpe astirpe force-pushed the 11_mig_l10n_nl_postcodeapi branch 2 times, most recently from c7c18f3 to 9257ef7 Compare June 22, 2018 06:38
@astirpe astirpe force-pushed the 11_mig_l10n_nl_postcodeapi branch from b5dc87f to 2dc38ed Compare July 23, 2018 06:57
@astirpe
[11.0][MIG] l10n_nl_postcodeapi
9167008 
Temporary workaround to make module usable (awaiting steffex/pyPostcode#16)
@astirpe astirpe force-pushed the 11_mig_l10n_nl_postcodeapi branch from 2dc38ed to 9167008 Compare July 23, 2018 07:29
@astirpe
Copy link
Member Author

astirpe commented Jul 23, 2018

Any chance to update the PyPI with the latest pyPostcode? Otherwise I would propose a solution to make this module not depending on that library.

@astirpe astirpe force-pushed the 11_mig_l10n_nl_postcodeapi branch from c0a6106 to 9167008 Compare July 24, 2018 08:40
@StefanRijnhart
Copy link
Member

@astirpe I'm sorry, I forgot that I have those privileges on the PyPostcode project. I released 0.5 https://pypi.org/project/pyPostcode/ /cc @steffex

@astirpe
Copy link
Member Author

astirpe commented Jul 31, 2018

Thanks!

@hbrunn hbrunn merged commit f94239e into OCA:11.0 Sep 5, 2018
@astirpe astirpe deleted the 11_mig_l10n_nl_postcodeapi branch September 5, 2018 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbrunn hbrunn hbrunn approved these changes

@CasVissers-360ERP CasVissers-360ERP CasVissers-360ERP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@astirpe @CasVissers-360ERP @StefanRijnhart @hbrunn @sbidoul @pedrobaeza @oca-transbot @ploegvde