Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][MIG] l10n_nl_bank #170

Merged
merged 2 commits into from
Jul 3, 2018
Merged

[11.0][MIG] l10n_nl_bank #170

merged 2 commits into from
Jul 3, 2018

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Jun 12, 2018

No description provided.

* New module l10n_nl_banks

* Remove blanc sections

* Icon credits

* OCA Requested changes

* Change module name

* Changes to comply with OCA
@astirpe astirpe mentioned this pull request Jun 12, 2018
9 tasks
@astirpe astirpe changed the title [11.0][MIG] l10n nl bank [11.0][MIG] l10n_nl_bank Jun 12, 2018
Images
------

* Bank image: <http://www.iconninja.com/banking-icon-466530>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find license information on this website. Maybe better use the opportunity to get a creative commons one from the noun project?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Member

@hbrunn hbrunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest looks good

@astirpe
Copy link
Member Author

astirpe commented Jun 22, 2018

Commits squashed

Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@yung-wang yung-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine here.

@hbrunn hbrunn merged commit 2c3c711 into OCA:11.0 Jul 3, 2018
@astirpe astirpe deleted the 11_mig_l10n_nl_bank branch July 3, 2018 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants