New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] [12.0] l10n_nl_partner_name #251
Conversation
from 8.0 to 10.0 [MIG] Migrates l10n_nl_partner_salutation from 8.0 to 10.0 Adding a commiter, changing the format of the licence comment, removing deprecated Char init variable [FIX] Sort version of licencing, removing VIM comments, changing __openerp__ to __manifest__ [FIX] Adding tests to increase code coverage [FIX] Replaces api.one with api.multi and inserting api.model [FIX] Adds newlines on the xmls, adds licence on manifest, changes name of compute methods [FIX] Creates the res_partner_title_sir in the module instead on the base module
* [DEL] obsolete manifest * [IMP] allow to fill in names in a more natural way
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-netherlands-11.0/l10n-netherlands-11.0-l10n_nl_partner_name Translate-URL: https://translation.odoo-community.org/projects/l10n-netherlands-11-0/l10n-netherlands-11-0-l10n_nl_partner_name/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, functional review.
@hbrunn Might be an issue of partner_firstname? |
I don't really understand what I see. When you reset the email address, the contact form changes? This looks to me like there's some form that needs the correct conditional invisibility |
we'll need a fix for |
I don't have time to investigate why tests of |
When a partner has no e-mail set, and you want to send out a sale order or invoice. Odoo prompts for an e-mail. In the view first_name and last_name is shown although the contact of the object is a company. |
@CasVissers thanks, this should be fixed now @astirpe anybody else can dig into this too, so I don't see you as the one who is solely responsible to fix this. 'Fixing' tests by deactivating them is something I only want to do in exceptional cases. Probably the issue is the new year, so we might have to make some of the dates involved in the tests relative to the current date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thnx, fixes the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
This PR has the |
/ocabot merge nobump |
On my way to merge this fine PR! |
It looks like something changed on |
Congratulations, your PR was merged at 279b3e0. Thanks a lot for contributing to OCA. ❤️ |
No description provided.