-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.0] l10n_nl_partner_name improvements #128
[10.0] l10n_nl_partner_name improvements #128
Conversation
ad1977e
to
0b37538
Compare
PS: Contrary to the screenshot, I swapped first name and initials after talking to my colleagues |
f63c09b
to
56964c6
Compare
@NL66278 looks like there's still a button box or an oe_left or oe_right active on your form |
@hbrunn The initials and infix field are very small. You hardly can see what you type. Should we add some more width to the fields? |
@hbrunn Could you please rebase this one? We have a merge conflict now. |
56964c6
to
7ad2ae6
Compare
7ad2ae6
to
4751bc3
Compare
Maybe bump the version, because this pull requests changes views, that can break inherited views? |
4751bc3
to
8d66a52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Code review and test
@StefanRijnhart This no longer needs fixing (has been done), but I cannot remove the label. |
@StefanRijnhart LGTM Only possible improvement can be to increase infix to 7 characters (van der) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional test (in v11)
@hbrunn Only possible improvement can be to increase infix to 7 characters (van der) |
* [DEL] obsolete manifest * [IMP] allow to fill in names in a more natural way
* [DEL] obsolete manifest * [IMP] allow to fill in names in a more natural way
* [DEL] obsolete manifest * [IMP] allow to fill in names in a more natural way
* [DEL] obsolete manifest * [IMP] allow to fill in names in a more natural way
* [DEL] obsolete manifest * [IMP] allow to fill in names in a more natural way
* [DEL] obsolete manifest * [IMP] allow to fill in names in a more natural way
* [DEL] obsolete manifest * [IMP] allow to fill in names in a more natural way
* [DEL] obsolete manifest * [IMP] allow to fill in names in a more natural way
* [DEL] obsolete manifest * [IMP] allow to fill in names in a more natural way
this started with wanting to have the form look like
the rest are fixes I came across on the way. I'm of a mind to propose a similar patch for
partner_firstname
, but that's slightly more tricky because there, we've got to cope with different name orders.Another thing I've in mind (but nobody paying for it) is to make infix and prefix configurable, possibly on group level. Then users can decide if the want to use only infixes, only prefixes or both. The forms then can be adapted with appropriate group specific views
depends on OCA/server-tools#1090