-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][FIX] l10n_nl_xaf_auditfile_export: exclude section and note move lines #375
[14.0][FIX] l10n_nl_xaf_auditfile_export: exclude section and note move lines #375
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM functional review.
l10n_nl_xaf_auditfile_export/tests/test_l10n_nl_xaf_auditfile_export.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please adapt the test class
d47a527
to
ca624bd
Compare
@astirpe The account.move.line's have apparently not been flushed to the database when get_move_line_count is called. I replaced the SQL select with an ORM search_count in the 15.0 migration. That solves the problem. As retrieving a single count will have a neglegible effect on performance (as date is indexed), I think this is the way to solve this. Tried first with a flush(0 on the model before the SQL selecct, but that had no effect. My 15.0 commit is here: |
@NL66278 it works now, thank you! |
@astirpe Please rebase on current 14.0 |
802fd0d
to
9e3ef58
Compare
@NL66278 done, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
This PR has the |
/ocabot merge minor |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 436d748. Thanks a lot for contributing to OCA. ❤️ |
Fixes #348