Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] XAF Audit file improvements #348

Closed
CasVissers-360ERP opened this issue Mar 30, 2022 · 0 comments · Fixed by #375
Closed

[14.0] XAF Audit file improvements #348

CasVissers-360ERP opened this issue Mar 30, 2022 · 0 comments · Fixed by #375
Labels

Comments

@CasVissers-360ERP
Copy link

CasVissers-360ERP commented Mar 30, 2022

Hi all,

Have some improvements which I think could be beneficial:

  1. Do not included move lines with a display_type:
    <trLine t-foreach="m.line_ids" t-as="l"> ->>> <trLine t-foreach="m.line_ids.filtered(lambda l: not l.display_type)" t-as="l">
  2. Add state checks:
    add "and parent_state = 'posted' ", to queries:
    get_move_line_total_credit
    get_move_line_total_debit
    get_move_line_count
    get_ob_totals
    EDIT: There is a PR for this: [14.0][FIX] Only include move lines that have been posted in the SQL queries #325

@antonioburic your work on the module triggered me with some improvements I had in mind.

Cas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant