Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] module l10n_nl_bsn 8.0 #38

Merged
merged 2 commits into from
Mar 1, 2016
Merged

[ADD] module l10n_nl_bsn 8.0 #38

merged 2 commits into from
Mar 1, 2016

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Mar 1, 2016

This module adds the BSN (Burgerservicenummer) field on partner forms.

I propose to use this module as a common basis for further developments.
Any feedback would be very appreciated.


from openerp import fields, models, api
from openerp.tools.translate import _
from stdnum.nl import bsn

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use an import that does not fail when the module is not available.
See https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md , External dependencies

@hbrunn hbrunn added this to the 8.0 milestone Mar 1, 2016
@hbrunn
Copy link
Member

hbrunn commented Mar 1, 2016

👍

1 similar comment
@RoelAdriaans
Copy link

👍

@lfreeke
Copy link
Contributor

lfreeke commented Mar 1, 2016

👍 (test)

hbrunn added a commit that referenced this pull request Mar 1, 2016
@hbrunn hbrunn merged commit bea8676 into OCA:8.0 Mar 1, 2016
@StefanRijnhart
Copy link
Member

I know this has already been merged (too soon, for my taste), but there are legal aspects that need to be taken into account. It is forbidden to use the BSN if this is not required by a legal context. See https://autoriteitpersoonsgegevens.nl/nl/onderwerpen/identificatie/burgerservicenummer-bsn. One such legal context is HR management, so this change would make much more sense on the employee model instead of the partner model. Can you at least mention the legal considerations in the README?

@hbrunn
Copy link
Member

hbrunn commented Mar 2, 2016

@StefanRijnhart good point, I did not think about this aspect at all, shame on me

@astirpe
Copy link
Member Author

astirpe commented Mar 2, 2016

Hi, as per the link above, the BSN can be user by some kind of organizations:

Dit geldt bijvoorbeeld voor zorgverleners, zoals huisartsen, apotheken en zorgverzekeraars

If we want to make Odoo more useful for these type of organizations, this module is a good addition in my opinion.

It is forbidden to use the BSN if this is not required by a legal context.

Good point 👍
That indeed should be mentioned in the README!

@hbrunn
Copy link
Member

hbrunn commented Mar 2, 2016

@astirpe will you PR a change to the readme? Of course, we need to keep this module, only people should be aware of the legal issues

@astirpe
Copy link
Member Author

astirpe commented Mar 2, 2016

Please check #39
Thank you!

@andreschenkels
Copy link
Member

I would also expect the BSN to be available and usefull on the employee. For companies the BSN == VAT so when do we need this field on partners?

@nielsmiddeldorp
Copy link

I would suggest that the BSN only shows on the partner if it not a company. BSN is not only for employees but also for customers that are a person. E.g. a client of a health Insurance company.

@StefanRijnhart
Copy link
Member

@nielsmiddeldorp valid use case, indeed.

@astirpe
Copy link
Member Author

astirpe commented Mar 2, 2016

I confirm that the BSN only shows on the partner if it not a company.

@ehahouimohssine
Copy link

For security reasons this should be only visible to HR related roles. Otherwise this will be in violation to the security framework of WBP regarding the protection of persons info.

@astirpe
Copy link
Member Author

astirpe commented Mar 3, 2016

Thanks @ehahouimohssine !
Please check PR #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants