-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] module l10n_nl_bsn 8.0 #38
Conversation
|
||
from openerp import fields, models, api | ||
from openerp.tools.translate import _ | ||
from stdnum.nl import bsn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use an import that does not fail when the module is not available.
See https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md , External dependencies
👍 |
1 similar comment
👍 |
👍 (test) |
I know this has already been merged (too soon, for my taste), but there are legal aspects that need to be taken into account. It is forbidden to use the BSN if this is not required by a legal context. See https://autoriteitpersoonsgegevens.nl/nl/onderwerpen/identificatie/burgerservicenummer-bsn. One such legal context is HR management, so this change would make much more sense on the employee model instead of the partner model. Can you at least mention the legal considerations in the README? |
@StefanRijnhart good point, I did not think about this aspect at all, shame on me |
Hi, as per the link above, the BSN can be user by some kind of organizations:
If we want to make Odoo more useful for these type of organizations, this module is a good addition in my opinion.
Good point 👍 |
@astirpe will you PR a change to the readme? Of course, we need to keep this module, only people should be aware of the legal issues |
Please check #39 |
I would also expect the BSN to be available and usefull on the employee. For companies the BSN == VAT so when do we need this field on partners? |
I would suggest that the BSN only shows on the partner if it not a company. BSN is not only for employees but also for customers that are a person. E.g. a client of a health Insurance company. |
@nielsmiddeldorp valid use case, indeed. |
I confirm that the BSN only shows on the partner if it not a company. |
For security reasons this should be only visible to HR related roles. Otherwise this will be in violation to the security framework of WBP regarding the protection of persons info. |
Thanks @ehahouimohssine ! |
This module adds the BSN (Burgerservicenummer) field on partner forms.
I propose to use this module as a common basis for further developments.
Any feedback would be very appreciated.