Make BSN visible to HR Officer users. #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One miniscule bug: When having a valid BSN number for a partner, then changing it to an invalid number, save and get the correct warning, finally change it back to the original valid number, you will get a "Another person (Administrator) has the same BSN [...]" warning. |
|
Yess it's a bug, I will fix it asap! Or feel free to open a PR. Thank you @pankk ! |
|
This is not a security measure but only UI. Either actually suppress reading the field as non-privileged user by overriding |
|
👍 |
1 similar comment
|
👍 |
hbrunn
added a commit
that referenced
this pull request
Mar 21, 2016
Make BSN visible to HR Officer users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For security reasons this should be only visible to HR related roles. Otherwise this will be in violation to the security framework of WBP regarding the protection of persons info.