-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] 8.0 l10n_nl_intrastat #58
Closed
Closed
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
91065dd
import code from launchpad
thomaspaulb 40cd297
bump version
thomaspaulb 96cd2db
Repair broken check_generate_lines call
thomaspaulb 6a5a0d5
encoding, folder structure
thomaspaulb 2faf739
tests: generation of report and checking of total amount
thomaspaulb 0509415
linting fixes
thomaspaulb 2592b22
readme
thomaspaulb c2a9a59
flake8
thomaspaulb 09aec5f
flake
thomaspaulb 53554dd
short license headers and flake errors
thomaspaulb 9871f31
oca dependencies
thomaspaulb 0157b1d
Merge branch '8.0' into 8.0-mig-l10n_nl_intrastat
hbrunn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| partner-contact https://github.com/OCA/partner-contact 8.0 | ||
| intrastat https://github.com/sunflowerit/intrastat 8.0-intrastat_base-tests | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Module
intrastat_baseis available in OCA for V8, so I think you can set the OCA repositoryintrastathere, instead of the sunflowerit branch. Or is it a temporary solution for some reason?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was probably not merged at the time of the PR, so this was necessary to get the tests right. But by now, this should indeed just be 'intrastat'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(took the liberty to do exactly that in order to continue with this)