[14.0][REF+IMP] mrp_attachment_mgmt: Cleanup + button in production orders #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @victoralmau, |
pedrobaeza
changed the title
pedrobaeza
force-pushed
the
14.0-mrp_attachment_mgmt-production
branch
from
f9c24c9
to
0fd8db8
Compare
- Put the method on product, and call it from all the places. - Remove excessive method fragmentation w/o gain. - Replace action read by proper `_for_xml_id` call.
pedrobaeza
force-pushed
the
14.0-mrp_attachment_mgmt-production
branch
from
0fd8db8
to
42f59d3
Compare
chienandalu
approved these changes
Mar 27, 2023
ernestotejeda
approved these changes
Mar 30, 2023
|
/ocabot merge minor |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 8dca420. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[REF] mrp_attachment_mgmt: Avoid code duplication for attachment view
_for_xml_idcall.[IMP] Add smart-button to production orders
@Tecnativa