Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][MIG] mrp_production_note #462

Merged
merged 18 commits into from
Feb 10, 2020

Conversation

lbelorgey
Copy link
Contributor

Standard migration of module mrp_production_note.

oihane and others added 17 commits January 18, 2020 12:19
Squashed commit:

[22ba5c7] [FIX] remove en.po that was erroneously created by transbot

[c911035] OCA Transbot updated translations from Transifex

[1ecefef] OCA Transbot updated translations from Transifex

[316efe4] OCA Transbot updated translations from Transifex
Squashed commit:

[60213de] OCA Transbot updated translations from Transifex

[8ad1474] OCA Transbot updated translations from Transifex

[0565e17] OCA Transbot updated translations from Transifex

[287c9b5] OCA Transbot updated translations from Transifex

[48e131e] OCA Transbot updated translations from Transifex
Currently translated at 100.0% (2 of 2 strings)

Translation: manufacture-10.0/manufacture-10.0-mrp_production_note
Translate-URL: https://translation.odoo-community.org/projects/manufacture-10-0/manufacture-10-0-mrp_production_note/de/
@lbelorgey lbelorgey mentioned this pull request Jan 18, 2020
17 tasks
@elvise
Copy link

elvise commented Jan 19, 2020

Hi, any good news for merge...?
If I can help please let me know...

Copy link
Member

@ps-tubtim ps-tubtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test ok but I have some comment.

Comment on lines +1 to +3
* Oihane Crucelaegui <oihanecrucelaegi@avanzosc.es>
* Pedro M. Baeza <pedro.baeza@serviciosbaeza.com>
* Ana Juaristi <anajuaristi@avanzosc.es>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add you as contributor.

mrp_production_note/readme/USAGE.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@marylla marylla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there,
I made a functional review. LGTM. :)

@LoisRForgeFlow
Copy link
Contributor

Hi @lbelorgey,

Can you squash your migration commits into one? This one is probably ready to merge.

@ps-tubtim Could you update your review?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@LoisRForgeFlow
Copy link
Contributor

/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-462-by-LoisRForgeFlow-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 10, 2020
Signed-off-by LoisRForgeFlow
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-462-by-LoisRForgeFlow-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 10, 2020
Signed-off-by LoisRForgeFlow
@OCA-git-bot OCA-git-bot merged commit 0cfdc8c into OCA:12.0 Feb 10, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0cca3f7. Thanks a lot for contributing to OCA. ❤️

@lbelorgey lbelorgey deleted the 12.0-mig-mrp_production_note branch February 10, 2020 19:35
rvalyi pushed a commit to akretion/manufacture that referenced this pull request Mar 3, 2020
Signed-off-by LoisRForgeFlow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.