Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Fix broken website links #920

Merged

Conversation

SirTakobi
Copy link

@SirTakobi SirTakobi commented Dec 20, 2022

Fixed a few website links.

In the last commit I updated the repo template (see https://github.com/OCA/oca-addons-repo-template) because it was failing.

@SirTakobi SirTakobi marked this pull request as ready for review December 20, 2022 14:38
@SirTakobi SirTakobi marked this pull request as draft December 20, 2022 14:42
@SirTakobi SirTakobi force-pushed the 12.0-fix-mrp_production_filter_lot-website branch from f24b193 to 1e3b2e7 Compare December 20, 2022 14:45
@SirTakobi SirTakobi changed the title [REF] mrp_production_filter_lot: Website link [REF] Fix broken website links Dec 20, 2022
@SirTakobi SirTakobi marked this pull request as ready for review December 20, 2022 14:52
@SirTakobi
Copy link
Author

@OCA/manufacturing-maintainers can someone please have a look?
It should be quick, this is only fixing broken links and updating CI configuration.
If you want me to split the commits in many PRs it is not a problem.

Comment on lines 9 to +10
'website': "https://github.com/OCA/manufacture"
"12.0/mrp_production_filter_lot",
"/tree/12.0/mrp_production_filter_lot",
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow Dec 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct link should be only https://github.com/OCA/manufacture

Copy link
Author

@SirTakobi SirTakobi Jan 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for having a look!
In https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#11modules, both forms are accepted:

The website key must be https://github.com/OCA/<repo>, so as to provide the most relevant link to discover more information about the addon. That link shows the repository README. Alternatively https://github.com/OCA//tree//<addon> may be used, to provide a direct link to the addon README, which includes proper credits (authors, contributors and theirs companies), and links to the relevant information on the OCA website.

And personally, I prefer the link to the module because I think that if a user is clicking on a link in a module it is expecting information about the module itself and not information about a repository that happens to contain the module.

Since both links should be accepted, can you update your review?

@SirTakobi SirTakobi force-pushed the 12.0-fix-mrp_production_filter_lot-website branch from 1e3b2e7 to 154273d Compare March 23, 2023 11:51
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 23, 2023
@SirTakobi
Copy link
Author

@OCA/manufacturing-maintainers can someone please have a look? Thanks!

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 30, 2023
@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-920-by-gurneyalex-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 23756b2 into OCA:12.0 Nov 10, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 08772c8. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants