-
-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REF] Fix broken website links #920
[REF] Fix broken website links #920
Conversation
f24b193
to
1e3b2e7
Compare
@OCA/manufacturing-maintainers can someone please have a look? |
'website': "https://github.com/OCA/manufacture" | ||
"12.0/mrp_production_filter_lot", | ||
"/tree/12.0/mrp_production_filter_lot", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The correct link should be only https://github.com/OCA/manufacture
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for having a look!
In https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#11modules, both forms are accepted:
The website key must be https://github.com/OCA/<repo>, so as to provide the most relevant link to discover more information about the addon. That link shows the repository README. Alternatively https://github.com/OCA//tree//<addon> may be used, to provide a direct link to the addon README, which includes proper credits (authors, contributors and theirs companies), and links to the relevant information on the OCA website.
And personally, I prefer the link to the module because I think that if a user is clicking on a link in a module it is expecting information about the module itself and not information about a repository that happens to contain the module.
Since both links should be accepted, can you update your review?
1e3b2e7
to
154273d
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
@OCA/manufacturing-maintainers can someone please have a look? Thanks! |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 08772c8. Thanks a lot for contributing to OCA. ❤️ |
Fixed a few website links.
In the last commit I updated the repo template (see https://github.com/OCA/oca-addons-repo-template) because it was failing.