Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP] mrp_sale_info: Smartlink on sale order #943

Merged
merged 1 commit into from
Mar 8, 2023
Merged

[14.0][IMP] mrp_sale_info: Smartlink on sale order #943

merged 1 commit into from
Mar 8, 2023

Conversation

thomaspaulb
Copy link
Contributor

Forward port of #861

Smartlink on sale order to mrp.production related records. A direct copy of the code from sale_mrp_link.

@thomaspaulb
Copy link
Contributor Author

@ntsirintanis Could you review?

NL66278
NL66278 approved these changes Jan 11, 2023
View reviewed changes
Copy link

@NL66278 NL66278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

3 similar comments
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dreispt
Copy link
Sponsor Member

dreispt commented Jan 19, 2023

Isn't this an out of the box feature?

@thomaspaulb
Copy link
Contributor Author

@dreispt Not in this module: https://github.com/OCA/manufacture/tree/14.0/mrp_sale_info/views

hieulucky111
hieulucky111 approved these changes Mar 3, 2023
View reviewed changes
Copy link

@hieulucky111 hieulucky111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Code review

mrp_sale_info/__manifest__.py Show resolved Hide resolved
mrp_sale_info/models/sale_order.py Show resolved Hide resolved
@thomaspaulb
Copy link
Contributor Author

@hieulucky111 Thanks for the review - adjusted.

@OCA/manufacturing-maintainers ready for merge?

@pedrobaeza Since you were involved in the discussion of mrp_sale_info vs. sale_mrp_link before, maybe you have an opinion on this also.

@pedrobaeza pedrobaeza added this to the 14.0 milestone Mar 3, 2023
@pedrobaeza
Copy link
Member

Can you refresh me (put the link) of such conversation?

@thomaspaulb
Copy link
Contributor Author

@pedrobaeza

OCA/sale-workflow#1109

If that's the case, it's as simply as add such smart-button in the other module. Here the problem is not the button, but the method to get the link between the 2 records.

pedrobaeza
pedrobaeza approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-943-by-pedrobaeza-bump-major, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7fb0573 into OCA:14.0 Mar 8, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 52efd49. Thanks a lot for contributing to OCA. ❤️

@gfcapalbo
Copy link

similar MR to #861 , also ready to merge.

@thomaspaulb thomaspaulb mentioned this pull request Mar 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NL66278 NL66278 NL66278 approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@hieulucky111 hieulucky111 hieulucky111 approved these changes

@ntsirintanis ntsirintanis ntsirintanis approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
8 participants
@thomaspaulb @OCA-git-bot @dreispt @pedrobaeza @gfcapalbo @NL66278 @hieulucky111 @ntsirintanis