Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] Show unit price when qty is not 1 #56

Merged
merged 1 commit into from
Oct 2, 2015

Conversation

antespi
Copy link

@antespi antespi commented Sep 29, 2015

When qty is not 1 (for example, 2, 3 or 0.56) POS ticket template (PosTicket) is not indicating unit price (but XmlReceipt template, used when proxy configured, implement this feature).
This is specially useful in this addon because unit price would not be product list_price because price list are applied even taking care customer.

So, with this improvement, if qty is equal to 1, unit price is not shown (as now occurs) but if qty is not equal to 1, then unit price is shown.

Please, @ah-taktik and @pablocm-aserti review these changes and do your comments, thanks.

@legalsylvain legalsylvain added this to the 8.0 milestone Sep 29, 2015

module.PosBaseWidget.include({
format_pr: function(amount, precision) {
console.log('format_pr: amount = ' + amount)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove console.log.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, in a moment. I'm waiting to finish runbot to see if any other fix is required.

@JavierIniesta
Copy link

Tested in runbot 👍

@janetrp
Copy link

janetrp commented Sep 29, 2015

really useful 👍

@rafaelbn
Copy link
Member

Tested in runbot 👍

@rafaelbn
Copy link
Member

@legalsylvain could make last review? I think it could be merged and change is not critical.
cc @pedrobaeza

@antespi
Copy link
Author

antespi commented Sep 30, 2015

Version increment, squash and rebase done.

@pedrobaeza
Copy link
Member

👍

pedrobaeza added a commit that referenced this pull request Oct 2, 2015
[IMP] Show unit price when qty is not 1
@pedrobaeza pedrobaeza merged commit 9be1ad5 into OCA:8.0 Oct 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants