-
-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make branch 8.0 the default #4
Comments
👍 |
On 07/22/2014 02:57 PM, Sandy wrote:
👍 |
Ping! |
Hello, I have no access, @sebastienbeau can but he is on holiday till Monday. Now a question: some projects may still undergo some non backward compatible changes even for yet a few months. This will be the case of l10n-brasil but also may be fiscal rules if we try to be somewhat pluggable with the work of @blaggacao. In these cases, could we have a master branch and no 8.0 branch until we decide we may maintain it backward compatible? I don't know if that was the intention but for instance C2C don't have a 8.0 branch for l10n-switzerland either https://github.com/OCA/l10n-switzerland What do you think? |
I think we should tag it as 8.0-dev or 7.0-dev, but not as master. Regards. |
👍 for Pedro's suggestion |
👎 for master as I think we should mirror Odoo the branch naming convention. It makes it easier for automated tools to figure out which repos to get if they have uniform naming Odoo master is labeled 9.0 when you run it. We could tag as 8.0-dev, but honestly, a branch with the name 8.0 and all the modules put in unported says the same thing and we don't have to rely on an admin to add the branches once we move out fo dev. |
I'm in complete mental disorder about all this github topics. I was pinged, so I feel, that something might concern me without figuring out what. The work I did was originally done in saas5 and then views etc. adapted so that it works in V8rc1. Now I'm developing a generic module in order to register by which document a partner is identified for countries where this is necesary as there is none around on OCA. I'm doing this in the new reckrdset style and using the new api. I hope, someone who knows more about the topic can make sense of this information. (I cannot even figure out if its relevant), sry & thanks. |
I'm all for following SA conventions but in fact OpenERP SA used master until they create a 8.0 branch. Dependent OCA modules should not only cope with the change in usptream Odoo but should also do their own cleanup / refactoring so in fact I see it just like Odoo convention but with a lag and until OpenERP SA starts working with roadmaps and schedules I don't see it possible not having a significant lag before telling "some OCA modules on new branch release X is stable now". @bwrsandman if we have the modules in unported in a 8.0 branch, can we still have Travis testing them easily? Is there some flag to activate this? |
For the moment, the proposed flow is that you make a PR, extracting the module from |
On 08/02/2014 05:00 PM, Sandy wrote:
I think the official repos should only contain official branches. That |
Interesting discussion, but I just need a small edit on this repo's configurations. Exactly who can? Isn't there a way for repo maintainers to be able to do it? |
Ping! |
Done. Sincere apologies for this taking so long, I've had a huge backlog to process when coming back from vacations... |
Thanks, @gurneyalex. This is a general task that must be accomplished on each project. Can you take care of it? There are some of them that has PRs to master (as there is no 8.0 branch in that moment), so you have to take in account. Let me know if I can help you. Regards. |
I'll take care of this. |
Mostly done AFAICT. Please ping me if I missed some. |
Hi, @gurneyalex, thanks for the work. There is still some repos that doesn't have 8.0 branch because we are waiting for PEP8 fix on 7.0, and then make it out of that branch. If you don't mind, I'll tell you when default switch can be made. For now, can you please do it for https://github.com/OCA/hr-timesheet? Regards. |
@gurneyalex Thanks! |
@pedrobaeza done for hr-timesheet. Please make separate issues on the appropriate projects, in order to keep things tidy. I'm back and running and processing the notification emails as they come :-) |
Can only be done by a member of the OCA organization.
The text was updated successfully, but these errors were encountered: