revert the framework to use product.product #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Seems reasonable. |
5 tasks
|
Tests on framework agreement are failing |
|
You're right @yvaucher. I have to revert the tests as well. |
for openerp 7.0, the framework agreement was attached to a product.product. While porting to odoo 8.0, initially it was changed to be attached to a product.template instead. After more thinking, it turns out that an agreement should indeed be associated to a specific variant, because variants can have different prices. In the demo data, we want an agreement on the ipad (32GB), not on a generic ipad.
lepistone
force-pushed
the
framework_product_product
branch
from
004bb44
to
bfb181e
Compare
|
Tests were fine, they were exposing a real bug! It's fixed now @yvaucher. |
|
👍 |
|
@pedrobaeza "Seems reasonable." is it a 👍 ? |
|
Yeah, sorry. I thought I put it. My 👍 |
pedrobaeza
added a commit
that referenced
this pull request
Oct 24, 2014
revert the framework to use product.product
|
@pedrobaeza thx |
bealdav
pushed a commit
to akretion/purchase-workflow
that referenced
this pull request
Mar 28, 2018
add .mailmap to fix authors for git-shortlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for openerp 7.0, the framework agreement was attached to a
product.product. While porting to odoo 8.0, initially it was changed to
be attached to a product.template instead.
After more thinking, it turns out that an agreement should indeed be
associated to a specific variant, because variants can have different
prices. In the demo data, we want an agreement on the ipad (32GB), not
on a generic ipad.