-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
port framework_agreement_sourcing to 8.0 #11
port framework_agreement_sourcing to 8.0 #11
Conversation
Warning:
logistic_requisition_source_id was removed from sale.order |
@yvaucher well spotted, you're right. That method needs to be adapted then, let's talk about it when you want. Thanks! |
@@ -24,11 +24,11 @@ | |||
|
|||
|
|||
class logistic_requisition_cost_estimate(orm.Model): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should certainly be a TransientModel
Specifically, the field logistic_requisition_source_id is not there anymore.
It does not seem to make much difference from the original one in logistic_requisition.
The agreement field should already have a domain: no need to check with an onchange that a consistent choice is made.
c25eec6
to
f9b6415
Compare
Fixed as suggested by @yvaucher and rebased. |
I checked "functional testing". More testing would help for sure, but I think we can merge it. |
@lepistone can you rebase to relaunch travis ? |
We're 💚 🍏 |
In this case tender flow is byassed and confirmed PO will be generated | ||
when logistic requisition is confirmed. | ||
In this case the tender flow is bypassed and confirmed PO will be generated | ||
when the logistic requisition is confirmed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In description bellow this comment:
s/generating/generated/
s/currences/currencies/
appart from non blocking typo 👍 |
typo fixed. |
👍 thx |
port framework_agreement_sourcing to 8.0
this broke the build probably because depending on #14 |
Dependencies:
Checklist: