Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port framework_agreement_sourcing to 8.0 #11

Merged
merged 15 commits into from
Oct 31, 2014

Conversation

lepistone
Copy link
Member

Dependencies:

Checklist:

  • make tests pass in v8
  • lint
  • functional test

@yvaucher
Copy link
Member

Warning:

File ".../vertical-ngo/framework_agreement_sourcing/model/logistic_requisition_cost_estimate.py", line 93, in cost_estimate
      if x and x.logistic_requisition_source_id.procurement_method
  AttributeError: 'sale.order.line' object has no attribute 'logistic_requisition_source_id'

logistic_requisition_source_id was removed from sale.order

@lepistone
Copy link
Member Author

@yvaucher well spotted, you're right. That method needs to be adapted then, let's talk about it when you want. Thanks!

@@ -24,11 +24,11 @@


class logistic_requisition_cost_estimate(orm.Model):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should certainly be a TransientModel

Specifically, the field logistic_requisition_source_id is not there
anymore.
It does not seem to make much difference from the original one in
logistic_requisition.
The agreement field should already have a domain: no need to check with
an onchange that a consistent choice is made.
@lepistone lepistone force-pushed the port_framework_agreement_sourcing branch from c25eec6 to f9b6415 Compare October 31, 2014 08:18
@lepistone
Copy link
Member Author

Fixed as suggested by @yvaucher and rebased.

@lepistone
Copy link
Member Author

I checked "functional testing". More testing would help for sure, but I think we can merge it.

@yvaucher
Copy link
Member

@lepistone can you rebase to relaunch travis ?

@lepistone
Copy link
Member Author

We're 💚 🍏

In this case tender flow is byassed and confirmed PO will be generated
when logistic requisition is confirmed.
In this case the tender flow is bypassed and confirmed PO will be generated
when the logistic requisition is confirmed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In description bellow this comment:
s/generating/generated/
s/currences/currencies/

@yvaucher
Copy link
Member

appart from non blocking typo 👍

@lepistone
Copy link
Member Author

typo fixed.

@yvaucher
Copy link
Member

👍 thx

gurneyalex added a commit that referenced this pull request Oct 31, 2014
@gurneyalex gurneyalex merged commit 01f8593 into OCA:8.0 Oct 31, 2014
@gurneyalex
Copy link
Member

this broke the build probably because depending on #14

@lepistone lepistone deleted the port_framework_agreement_sourcing branch November 10, 2014 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants