[REF] javascript-lint: Usability boost #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moylop260
approved these changes
Jan 17, 2018
moylop260
changed the title
|
Why Travis error? |
|
Because dangling variables are errors, as they are currently in python too. |
|
But then we should fix them... |
|
Oh sorry I misunderstood you, you mean the ❌ in travis right now... It seems the problem is here. |
yajo
changed the title
yajo
force-pushed
the
master-eslint-fail_on_unused_variables
branch
from
cc15403
to
e9d6dc7
Compare
|
OK, I have switched this PR's purpose. After using this eslint configuration for polishing OCA/website#402, I have realised many settings are not very accurate. Since I guess that's one of the few big, well-structured JS addons we have, I'm updating the template here. Last commit indicates the features introduced. |
- Enable `no-unused-vars` - Allow `continue` statements - Disable `guard-for-in` - Do not require `@returns` rules on methods that return nothing - Set standards for JSDoc
yajo
force-pushed
the
master-eslint-fail_on_unused_variables
branch
from
e9d6dc7
to
98f0e3b
Compare
pedrobaeza
approved these changes
Jan 18, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Tecnativa