[REF] duplicate-xml-record-id: Get xml section from manifest to skip different origin #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
different origin Fix OCA#83
pedrobaeza
reviewed
Dec 7, 2016
| @@ -118,8 +120,8 @@ def test_20_expected_errors(self): | |||
| pylint_res = self.run_pylint(self.paths_modules) | |||
| # Expected vs found errors | |||
| real_errors = pylint_res.linter.stats['by_msg'] | |||
| self.assertEqual(sorted(real_errors.items()), | |||
| sorted(EXPECTED_ERRORS.items())) | |||
| self.assertEqual(json.loads(json.dumps(EXPECTED_ERRORS)), | |||
pedrobaeza
reviewed
Dec 7, 2016
| for xml_file in self.filter_files_ext('xml', relpath=False): | ||
| all_xml_ids.extend(self.get_xml_records(xml_file)) | ||
| xml_records = [] | ||
| for fname, section in self._get_manifest_referenced_files().items(): |
There was a problem hiding this comment.
Add some comment here to explain that this only gets XML files from data section
There was a problem hiding this comment.
The method _get_manifest_referenced_files gets all type of files (Not only xml)
There was a problem hiding this comment.
OK, I get it. Then the comment should be: Check duplicated XML-IDs inside of the files of each section treated them separately
There was a problem hiding this comment.
Oh! Are you talking about docstring, right?
I got it
|
👍 |
alan196
approved these changes
Dec 9, 2016
|
Good suggestion 👍 |
|
Could we merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #83
Change test diff message in case of fails:
