Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] Support odoo tag in xml file #9

Merged
merged 1 commit into from
Oct 31, 2015
Merged

[IMP] Support odoo tag in xml file #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pylint_odoo/misc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,8 @@ def get_xml_records(self, xml_file, model=None):
else:
model_filter = "[@model='{model}']".format(model=model)
doc = self.parse_xml(xml_file)
return doc.xpath("/openerp//record" + model_filter) \
return doc.xpath("/openerp//record" + model_filter) + \
doc.xpath("/odoo//record" + model_filter) \
if not isinstance(doc, basestring) else []

def get_xml_record_ids(self, xml_file, module=None):
Expand Down
28 changes: 0 additions & 28 deletions pylint_odoo/test_repo/broken_module/model_view.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,34 +11,6 @@
</form>
</field>
</record>
<!-- duplicate record id -->
<record id="view_model_form" model="ir.ui.view">
<field name="name">view.model.form</field>
<field name="model">test.model</field>
<field name="arch" type="xml">
<tree string="Test model">
<field name="name"/>
</tree>
</field>
</record>

<!--duplicate id but different module-->
<record id="base.view_model_form" model="ir.ui.view">
<field name="name">view.model.form</field>
<field name="model">test.model</field>
<field name="arch" type="xml">
<tree string="Test model">
<field name="name"/>
</tree>
</field>
</record>

<!--ir.filters without explicit user_id-->
<record id="filter_test_model" model="ir.filters">
<field name="name">By name</field>
<field name="model_id">test.model</field>
<field name="context">{'group_by': ['name']}</field>
</record>

</data>
</openerp>
34 changes: 34 additions & 0 deletions pylint_odoo/test_repo/broken_module/model_view_odoo.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
<?xml version="1.0" encoding="utf-8"?>
<odoo>
<data>
<!-- duplicate record id -->
<record id="view_model_form" model="ir.ui.view">
<field name="name">view.model.form</field>
<field name="model">test.model</field>
<field name="arch" type="xml">
<tree string="Test model">
<field name="name"/>
</tree>
</field>
</record>

<!--duplicate id but different module-->
<record id="base.view_model_form" model="ir.ui.view">
<field name="name">view.model.form</field>
<field name="model">test.model</field>
<field name="arch" type="xml">
<tree string="Test model">
<field name="name"/>
</tree>
</field>
</record>

<!--ir.filters without explicit user_id-->
<record id="filter_test_model" model="ir.filters">
<field name="name">By name</field>
<field name="model_id">test.model</field>
<field name="context">{'group_by': ['name']}</field>
</record>

</data>
</odoo>