[ADD][9.0]RMA (WIP) #110

AaronHForgeFlow · 2017-03-16T16:28:56Z

RMA

You use this module to manage RMA (Return Merchandise Authorization) in Odoo

The RMA can be send from the company to the customer or from the supplier to
the company

The RMA user creates the RMA and assign a responsible by selecting the
affected invoice. The available operations are refund, repair and deliver or
replace.
The assigned person checks if the conditions for the RMA are correct and
approve the RMA

The assigned person have to go to the RMA lines from the RMA and operate. THe
available options are creating receipts, delivery orders and refunds.

Once the assigned person considers that the RMA is settled he/she can
set the RMA to Done.

Configuration

To configure this module, you need to:

Go to Settings > Users and add the user to the group RMA manager
Go to Inventory > Settings > Return Merchandising Authorization and select
the option "Display 3 fields on rma: partner, invoice address, delivery
address" if needed
Go to Inventory > Settings > Configuration > Warehouse management >
Warehouses and add a default RMA location and RMA picking type for customers
and suppliers RMA picking type. It's very important to select the type of
operation supplier if we are moving in the company and customer if we are
moving out of the company.

Usage

RMA are accessible though Inventory menu. There's four menus, divided by type
. Users can access to the list of RMA or RMA lines.

Create an RMA:

Select a partner. Fill the rma lines by selecting an invoice.
Request approval and approve.
Click on RMA Lines button.
Click on more and select an option: "Receive products", "Create Delivery
Order, Create Refund"
Go back to the RMA. Set the RMA to done if not further action is required

Issues

You can also comment about this module in this issue: #111

OBS: Additional modules will allow to create RMA from SO or PO

rubencabrera · 2017-03-16T16:58:50Z

@drl9319
@carlosap92
@jesuspablo

nhomar · 2017-03-19T02:47:44Z

Dude I am really sorry.

But this is a copy of our work in Vauxoo/rma (may be with little changes).

I have several questions:

Why remove our authorship?
Why propose a PR to OCA/RMA first instead explain the changes into vauxoo/rma?.

We had invested on this work a HUGE amount of work and we are opensourcing everything, but IMHO this is not the way to propose a PR or a Refactor...

AFAICR we are all in the same team did not we?

cc @jbeficent

JordiBForgeFlow · 2017-03-19T09:15:04Z

@nhomar Obviously we have to respect the authorship. We'll add that ASAP!

We have been struggling with the current proposed approach in v8, and wanted to brainstorm with new ideas. We researched what has been done by your team, also we looked into Oracle, SAP, and Odoo v9 and v10, to try to identify new ideas to improve the process.

We did not see https://github.com/Vauxoo/rma/pull/167. And we are going to review it now.

We are happy to redirect the PR to Vauxoo/RMA and to work together on this!

@yaniaular I understand that you are under active development. We would be happy to discuss together.

AaronHForgeFlow · 2017-03-20T08:11:28Z

@nhomar Of course we will respect the authorship, that was not intended, apologizes for the misunderstanding.
I agree to move the PR to Vauxoo/RMA and keep up with the work together.
We will review your work at https://github.com/Vauxoo/rma/pull/167

pedrobaeza · 2017-03-20T08:40:05Z

You should move it to OCA, not to Vauxoo fork I think.

jgrandguillaume · 2017-03-22T16:45:25Z

Hi,

First of all thank you for refactoring this module, it is an very old one that we took back from a version 5.0 and never had the budget to clean it up ! I support this move, and like very much the new way of handling the supplier and customer RMA.

I've tested it and it works well overall. I have a few remarks:

In the previews versions, I was able to create a refund from a line, that I didn't succeeded. It was very useful and once agreed with management, the person in charge was able to create a refund for a customer automatically, avoiding mistakes (e.g. wrong price or qty). That was very much appreciated.
In my opinion, one of the most important feature in the previous module was to be able to let the system create the appropriate picking according to the infos set on the inventory tab of the product (supplier.info). There you were able to tel the system wether a product should go back to you, the supplier or another adresse (entity, e.g. for Smartphone, you don't return to the seller, not the manufacturer, but the entity in charge of the repair).
Previous behavior:

If set to company, the picking created was returning in the RMA location with address=company address
If set to supplier, the picking created was returning in the supplier location with address=supplier address
If set to other, the picking created was returning in the supplier location with address=specified address address

That was helpful, in our case, we used this to record the picking in the system, so our customer can then print the shipping label properly, send it back to the customer in order for him to ship back to the proper place (without costs in our case). Now I didn't figured out how to do this anymore.

In the previous version (again ;) ), the system computed also for each line if the warranty was still going on or not (well, it was based on the current value of the supplier infos, not historical, but well..better than nothing). That is IMO important to keep. We want to know before deciding what to do, if the warranty is still valid or not.

Apart from those points, I'm happy to support this refactoring !

Thanks again for the work,

👍

Joël

rubencabrera · 2017-04-26T11:05:17Z

I have a few points to review:

When creating an invoice from add_invoice_id on a Customer RMA, the invoice form loaded has the supplier label on partner, tried to use a context with {'default_type': 'out_invoice'} to fix it but can't make it work this way.
On the RMA lines, operation_id is readonly and required, son no manual lines can be added, just the ones generated adding an invoice. What if we don't have the invoice in odoo because we are migrating from another ERP?
When loading demo data, my warehouse and locations get overriden with the RMA ones in demo data. Is this intended? EDIT: this only happend on the backport I'm doing to 8.0, sorry for the inconvenience, I guess it's not that important anyway, the README explains quite well how to set RMA locations.

AaronHForgeFlow · 2017-04-26T13:04:53Z

Hello @rubencabrera,
Thanks for your feedback. Regarding your comments:

You're correct, I'll figure it out how to fix this
I'll remove those restrictions in order to allow to create manual lines.
The demo data is intended to no be updated (noupdate=1), I'll review this.

Merge changes after pulling from 9.0 PR OCA#110

rubencabrera

Undefined variables in _default_dest/src_location_id methods

rubencabrera · 2017-04-27T11:54:16Z

rma/models/rma.py

+    def _default_src_location_id(self):
+        if self.type == 'customer':
+            if self.rma_id.partner_id.property_stock_customer:
+                return lines.rma_id.partner_id.property_stock_customer.id


Isn't lines an undefined variable here and in line 440?

Yes, this method is not used indeed. I'll remove it. Thank you! @rubencabrera

andhit-r · 2017-05-20T11:02:14Z

rma/models/rma.py

+    @api.onchange('product_id')
+    def _onchange_product_id(self):
+        if not self.invoice_id:
+            return


Hi @aheficent , is this by design? If RMA unrelated to invoice then onchange will not fill name field. Meanwhile field name is readonly thus data can not be saved.

Hi @andhit-r Creating manual RMA lines was not possible at that time, but this design is going to be modified

andhit-r · 2017-05-20T15:00:04Z

rma/models/rma.py

+from openerp.exceptions import UserError
+from dateutil.relativedelta import relativedelta
+from openerp.tools import DEFAULT_SERVER_DATE_FORMAT
+import math


unused import

andhit-r · 2017-05-20T15:00:26Z

rma/models/rma.py

+from openerp.tools import DEFAULT_SERVER_DATE_FORMAT
+import math
+from datetime import datetime
+import calendar


unused import

andhit-r · 2017-05-20T15:01:15Z

rma/models/rma.py

+                                   default=lambda self: self.env.user)
+    company_id = fields.Many2one('res.company', string='Company',
+                                 default=lambda self: self.env.user.company_id)
+    rma_line_ids = fields.One2many('rma.order.line', 'rma_id',


You should make it readonly unless it's draft

andhit-r · 2017-05-20T15:07:48Z

rma/models/rma.py

+        if self.env.context.get('supplier'):
+            vals['name'] = self.env['ir.sequence'].get('rma.order.supplier')
+        else:
+            vals['name'] = self.env['ir.sequence'].get('rma.order')


IMO, the best way to assign sequence are according these flow:

Give a default value for name (e.g. /)

Remove readonly from field name, so user can override the sequence when they see fit

If no change needed (field name value == /) then assign sequence when data created

Just an opinion, no need to change if you don't see fit.

Thanks for your advice. It could be a good option.

andhit-r · 2017-05-20T15:09:30Z

rma/models/rma.py

+        self.move_count = len(list(set(move_list)))
+
+    @api.model
+    def _default_dest_location_id(self):


This method also unused

andhit-r · 2017-05-20T15:10:08Z

rma/models/rma.py

+    rma_id = fields.Many2one('rma.order', string='RMA',
+                             ondelete='cascade')
+    uom_id = fields.Many2one('product.uom', string='Unit of Measure')
+    product_id = fields.Many2one('product.product', string='Product',


Readonly unless its draft

AaronHForgeFlow · 2017-05-22T07:19:29Z

Thank you for you review @andhit-r I hope to include some improvements soon

berpweb · 2017-07-07T02:08:41Z

Guys any idea of pushing this PR forward?
@aheficent you still working on the improvements?

drl9319 · 2017-07-07T06:50:55Z

Hi guys. Now I working in migrate this code to V 8.0, fix some errors and add new funcionality.

I add module: rma_serial_number, this module allow select product and serial number, with this data the code can search the related invoice, (for example a big company have more mobile phone and a few moths since the company purchase this mobile have and problem with a unique serial number, but how this company have more invoices and pruchase order can't search the related invoice, for thah is this new funcionality).

The second funcionality is when the company have and rma from a invoice haven't in the system becouse it is from the old system. For thah we have create a new object rma_external_invoice_line with the invoice number, date, client/supplier and serial number.

can be this changes in this url: https://github.com/praxya/rma/tree/8.0-rma-serial-number

regards

AaronHForgeFlow · 2017-07-10T07:42:38Z

Hi @berpweb We are still working on this. Regards.

gurneyalex · 2017-07-17T06:52:25Z

Can you rebase the PR to solve the conflict?

JordiBForgeFlow · 2017-07-17T07:10:56Z

@gurneyalex this is our current working branch https://github.com/Eficent/rma/tree/9.0-rma-v2

As we have deviated significantly from 8.0 we may not finally propose to OCA/rma to respect the current desig, used already by others.

JordiBForgeFlow · 2017-07-27T16:18:44Z

We have decided to continue our diverging approach in https://github.com/Eficent/stock-rma

AaronHForgeFlow mentioned this pull request Mar 16, 2017

[RFC][9.0]RMA #111

Closed

AaronHForgeFlow changed the title ~~[ADD][9.0]RMA~~ [ADD][9.0]RMA (WIP) Mar 16, 2017

AaronHForgeFlow force-pushed the 9.0-rma branch from a72d4f3 to 675a4c0 Compare March 16, 2017 16:45

AaronHForgeFlow force-pushed the 9.0-rma branch 20 times, most recently from 8ce1294 to 7f9ab55 Compare March 17, 2017 16:57

AaronHForgeFlow force-pushed the 9.0-rma branch from d70cd75 to 684d09e Compare March 22, 2017 18:05

AaronHForgeFlow force-pushed the 9.0-rma branch 10 times, most recently from 5bc2c24 to 919ccc5 Compare April 25, 2017 16:56

[FIX]partner_delivery_address in procurements

99cfba9

AaronHForgeFlow force-pushed the 9.0-rma branch from 919ccc5 to 99cfba9 Compare April 25, 2017 17:11

[FIX]Nomenclature

54c1fc0

Rubén Cabrera and others added 2 commits April 26, 2017 18:05

Load customer invoice form for customer RMA

7ffe80c

[UPT]Shipment and refund types in operations

1c5ba52

AaronHForgeFlow force-pushed the 9.0-rma branch from 9a543e6 to 1c5ba52 Compare April 26, 2017 17:03

rubencabrera pushed a commit to rubencabrera/rma that referenced this pull request Apr 27, 2017

Merge branch 'merge-250417' into refactor

62b3a21

Merge changes after pulling from 9.0 PR OCA#110

rubencabrera reviewed Apr 27, 2017

View reviewed changes

andhit-r reviewed May 20, 2017

View reviewed changes

andhit-r suggested changes May 20, 2017

View reviewed changes

JordiBForgeFlow closed this Jul 27, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD][9.0]RMA (WIP) #110

[ADD][9.0]RMA (WIP) #110

AaronHForgeFlow commented Mar 16, 2017 •

edited

Loading

rubencabrera commented Mar 16, 2017

nhomar commented Mar 19, 2017 •

edited

Loading

JordiBForgeFlow commented Mar 19, 2017

AaronHForgeFlow commented Mar 20, 2017

pedrobaeza commented Mar 20, 2017

jgrandguillaume commented Mar 22, 2017

rubencabrera commented Apr 26, 2017 •

edited

Loading

AaronHForgeFlow commented Apr 26, 2017

rubencabrera left a comment

rubencabrera Apr 27, 2017

AaronHForgeFlow Apr 27, 2017

andhit-r May 20, 2017

AaronHForgeFlow May 22, 2017

andhit-r May 20, 2017

andhit-r May 20, 2017

andhit-r May 20, 2017

andhit-r May 20, 2017

AaronHForgeFlow May 22, 2017

andhit-r May 20, 2017

andhit-r May 20, 2017

AaronHForgeFlow commented May 22, 2017

berpweb commented Jul 7, 2017

drl9319 commented Jul 7, 2017

AaronHForgeFlow commented Jul 10, 2017

gurneyalex commented Jul 17, 2017

JordiBForgeFlow commented Jul 17, 2017 •

edited

Loading

JordiBForgeFlow commented Jul 27, 2017

[ADD][9.0]RMA (WIP) #110

[ADD][9.0]RMA (WIP) #110

Conversation

AaronHForgeFlow commented Mar 16, 2017 • edited Loading

RMA

Configuration

Usage

Issues

rubencabrera commented Mar 16, 2017

nhomar commented Mar 19, 2017 • edited Loading

JordiBForgeFlow commented Mar 19, 2017

AaronHForgeFlow commented Mar 20, 2017

pedrobaeza commented Mar 20, 2017

jgrandguillaume commented Mar 22, 2017

rubencabrera commented Apr 26, 2017 • edited Loading

AaronHForgeFlow commented Apr 26, 2017

rubencabrera left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AaronHForgeFlow commented May 22, 2017

berpweb commented Jul 7, 2017

drl9319 commented Jul 7, 2017

AaronHForgeFlow commented Jul 10, 2017

gurneyalex commented Jul 17, 2017

JordiBForgeFlow commented Jul 17, 2017 • edited Loading

JordiBForgeFlow commented Jul 27, 2017

AaronHForgeFlow commented Mar 16, 2017 •

edited

Loading

nhomar commented Mar 19, 2017 •

edited

Loading

rubencabrera commented Apr 26, 2017 •

edited

Loading

JordiBForgeFlow commented Jul 17, 2017 •

edited

Loading