[16.0][FIX] sale_channel_search_engine: Prevent MRO conflicts on registry load #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmignon
force-pushed
the
16.0-avoif-mro-conflict
branch
from
ebe546e
to
ada18d9
Compare
Avoid to create a new base model for product.product and product.category on top of the se.indexable.record model. Others addon could extends the product.product and product.category models to make it extendable. If such modules are mixed with an addon where defining a custome base class for the same models and inheriting from se.indexable.record, this will lead to an MRO conflict error when the odoo registry is initialized. This is the case for exemple when the ale_channel_search_engine_product and sale_channel_search_engine_category modules were used with the shopinvader_search_enfine module
lmignon
force-pushed
the
16.0-avoif-mro-conflict
branch
from
ada18d9
to
cd78825
Compare
qgroulard
approved these changes
Oct 9, 2023
|
/ocabot merge minor |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at fa207f5. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid to create a new base model for product.product and product.category on top of the se.indexable.record model. Others addon could extends the product.product and product.category models to make it extendable. If such modules are mixed with an addon where defining a custome base class for the same models and inheriting from se.indexable.record, this will lead to an MRO conflict error when the odoo registry is initialized. This is the case for exemple when the ale_channel_search_engine_product and sale_channel_search_engine_category modules were used with the shopinvader_search_enfine module