[15.0][MIG] sale_coupon_multi_gift: Migration to 15.0 #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This must be renamed to |
|
It depends on |
|
But should we split it to separate the multi_gift definition from the sales part? |
Now we use the product field in the multi gift line as a mask for a many2many field that can be used by a third module as a way to offer optional gifts to the user. TT30850
When we've got mixed optional rewards we need to tell for sure which reward line belongs a sale line to so we can apply the right product when the reward is updated. TT34266
chienandalu
force-pushed
the
15.0-mig-sale_coupon_multi_gift
branch
from
b976dea
to
cc662c8
Compare
Done |
2 tasks
|
/ocabot migration sale_coupon_multi_gift |
pedrobaeza
reviewed
Feb 16, 2023
chienandalu
force-pushed
the
15.0-mig-sale_coupon_multi_gift
branch
from
cc662c8
to
a15546f
Compare
|
Changes done |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 961c0db. Thanks a lot for contributing to OCA. ❤️ |
pilarvargas-tecnativa
pushed a commit
to Tecnativa/sale-promotion
that referenced
this pull request
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT39005
please review @CarlosRoca13 @victoralmau