Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] New repository: sale_discount #985

Closed
rousseldenis opened this issue Nov 5, 2019 · 13 comments
Closed

[RFC] New repository: sale_discount #985

rousseldenis opened this issue Nov 5, 2019 · 13 comments
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.

Comments

@rousseldenis
Copy link
Contributor

As mentionned by @lmignon in #729, and in order to decrease sale-workflow repository module numbers, we should try to identify some groups of modules that cover the same functional area.

For a start, why not creating a repository 'sale_discount' ?

@rafaelbn @pedrobaeza @lmignon @Cedric-Pigeon @OCA/crm-sales-marketing-maintainers

@pedrobaeza
Copy link
Member

Which are the candidates for this repo?

@rousseldenis
Copy link
Contributor Author

rousseldenis commented Nov 6, 2019

All sale_promotion_rule* (see v10), sale_discount_display_amount, sale_fixed_discount, ... and other I haven't found yet

@pedrobaeza
Copy link
Member

Then I would call it sale-price or similar.

@rousseldenis
Copy link
Contributor Author

Yes, that could be

@rousseldenis
Copy link
Contributor Author

You want me to call for that new repo on contributors mailing list ?

@rousseldenis
Copy link
Contributor Author

After discussion with colleagues, it was more oriented 'promotion', to restrict the scope. So sale-promotion is better

@lmignon
Copy link
Contributor

lmignon commented Nov 6, 2019

I'm in favor of sale-promotion

@pedrobaeza
Copy link
Member

OK about the name. You have to write to contribute at odoo-community dot org for asking for the repository.

@pedrobaeza
Copy link
Member

@rousseldenis have you written to contributors instead of contribute?

@rousseldenis
Copy link
Contributor Author

@rousseldenis have you written to contributors instead of contribute?

Yes, but never heard for contribute...

https://odoo-community.org/groups

@pedrobaeza
Copy link
Member

That's not a mailing list, but the alias of a project in OCA instance for creating the task for doing it, and it's the place to do the request (but not sure where is that documented inside OCA website).

@rousseldenis
Copy link
Contributor Author

(but not sure where is that documented inside OCA website).

😄 Ok, that's two different things. Will do it

@github-actions
Copy link

github-actions bot commented Apr 3, 2022

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 3, 2022
@github-actions github-actions bot closed this as completed May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

No branches or pull requests

3 participants