Port 7.0 add last sale price yvr #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is an error with this module tests. Can you check it, please? Regards. |
|
last_sale_price tests fail because of sale_stock: IntegrityError: null value in column "picking_policy" violates not-null constraint This module doesn't depends on sale_stock, thus it should be tested separately |
|
@yvaucher I think you can work around this by changing the travis configuration for the repository, in order to make separate tests for the modules which must not be tested with sale_stock installed. |
|
Separating last_sale_price test works though it seems there is still an error with sale_validity on other test. (this shouldn't have anything to do with last_sale_price) |
yvaucher
force-pushed
the
port-7.0-add-last_sale_price-yvr
branch
from
74f632d
to
9a784f1
Compare
|
Rebased |
|
The remaining failure comes from OCA/OCB#37 |
gurneyalex
force-pushed
the
port-7.0-add-last_sale_price-yvr
branch
from
9a784f1
to
0e26095
Compare
gurneyalex
force-pushed
the
port-7.0-add-last_sale_price-yvr
branch
from
0e26095
to
1d7614a
Compare
|
rebased on top of 7.0 |
|
👍 |
1 similar comment
|
👍 |
rousseldenis
pushed a commit
to acsone/sale-workflow
that referenced
this pull request
Jul 30, 2019
…w_payment_mode_setup-dro [12.0][IMP] sale_automatic_workflow_payment_mode: setup
lmignon
pushed a commit
to acsone/sale-workflow
that referenced
this pull request
Feb 11, 2021
cluster picking: implement /stock_issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.