[FIX] sale_delivery_term tests

[eLBati]

File "/home/travis/build/OCA/sale-workflow/sale_delivery_term/sale.py", line 241, in generate_detailed_lines
len(group_ids)))
except_orm: (u'Error', u'Delivery term lines are 4. Order line groups are 2. Please create more groups')

found at https://travis-ci.org/OCA/sale-workflow/jobs/32663504
because [(0, 0, {'quantity_perc': 0.5, 'delay': 15}),(0, 0, {'quantity_perc': 0.5, 'delay': 30})] run more than 1 time created more than 2 term lines

[coveralls]

Changes Unknown when pulling 5273d19 on eLBati:7.0_fix_sale_delivery_term_test into * on OCA:7.0*.

[pedrobaeza]

I think you can simply remove it.

[eLBati]

Thanks. Fixed

[eLBati]

OCB tests are red due to sale_exception_nostock

2014-08-18 10:01:12,788 23152 TEST openerp_test openerp.tools.yaml_import: Then my sale order should be in draft state and only related to no_stock_in_future exception
2014-08-18 10:01:12,790 23152 ERROR openerp_test openerp.tools.yaml_import: AssertionError in Python code : Incorrect state manual instead of draft

@nbessi any clue?

[pedrobaeza]

The problem can be solved in another PR.

For this, 👍 Please port it to 8.0.

[yvaucher]

On step forward to greenify those tests

Thanks

👍

[bwrsandman]

Error in OCB and not Odoo:

2014-08-18 10:38:38,923 23155 ERROR openerp_test openerp.tools.yaml_import: AssertionError in Python code : Incorrect state manual instead of draft

Why?

[eLBati]

@bwrsandman some additional info at #22 (comment)

[bwrsandman]

There wasn't really an answer. These tests seem to point out a regression in OCB, this needs to be adressed.

@StefanRijnhart any idea?

[eLBati]

Ported to 8 with #24

[eLBati]

About sale_exception_nostock error, just debugged and can report additional info.

When the test 'Then I confirm the the 26th of March firesteel order' confirms SO so_1

• Using OCB, at the end of future_orders_are_affected, prod_for_virtual_qty['virtual_available'] is 11000 and line.product_uom_qty is 10000. So, no exception is raised and the order is confirmed. The test fails because it expects the exception --> the order should stay draft.
• Using odoo, at the end of future_orders_are_affected, prod_for_virtual_qty['virtual_available'] is 500 and line.product_uom_qty is 10000. So, the exception is raised and the order stays draft --> the test doesn't fail

Did not investigate further, so I don't know who is right between OCB and odoo about the virtual_available amount

[bwrsandman]

@eLBati could you post an issue on https://github.com/OCA/OCB

[eLBati]

Done OCA/OCB#37

[pedrobaeza]

Can we proceed then with the merge of this PR?

[bwrsandman]

I'd rather wait until we get a solution on OCB as this is our active example.

[eLBati]

This PR fixes the tests of sale_delivery_term, so for me it can be merged

The references to this PR and the failing test stay on the OCB issue

[pedrobaeza]

As there is an issue opened, I proceed with this merge and continue talking on that issue.

Regards.