-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
16.0 mig sale order warn message #2610
16.0 mig sale order warn message #2610
Conversation
87b0932
to
eb65340
Compare
/ocabot migration sale_order_warn_message |
@@ -0,0 +1,2 @@ | |||
This module add a warning popup on sale to ensure warning is populated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This module add a warning popup on sale to ensure warning is populated | |
This module adds a warning popup on sale to ensure warning is populated |
@@ -0,0 +1,2 @@ | |||
This module add a warning popup on sale to ensure warning is populated | |||
no only when partner is changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no only when partner is changed. | |
not only when partner is changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description should be enhanced as it is not a popup but a permanent alert warning on sale order form.
An image of the form should be great too (optional).
@aiendry-aktivsoftware Don't forget that a meaningful PR title will help reviewers. Thanks |
eb65340
to
df1ad10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
Hi @aiendry-aktivsoftware could you rebase, please? THX |
/ocabot rebase |
Congratulations, PR rebased to 16.0. |
df1ad10
to
37db0b0
Compare
@HaraldPanten Done |
Closing as it has been superseded |
Standard migration to version 16.0