16.0 mig sale order warn message #2610
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiendry-aktivsoftware
force-pushed
the
16.0-mig-sale_order_warn_message
branch
from
87b0932
to
eb65340
Compare
|
/ocabot migration sale_order_warn_message |
rousseldenis
requested changes
Jul 20, 2023
| @@ -0,0 +1,2 @@ | |||
| This module add a warning popup on sale to ensure warning is populated | |||
There was a problem hiding this comment.
Suggested change
| This module add a warning popup on sale to ensure warning is populated | |
| This module adds a warning popup on sale to ensure warning is populated |
| @@ -0,0 +1,2 @@ | |||
| This module add a warning popup on sale to ensure warning is populated | |||
| no only when partner is changed. | |||
There was a problem hiding this comment.
Suggested change
| no only when partner is changed. | |
| not only when partner is changed. |
There was a problem hiding this comment.
The description should be enhanced as it is not a popup but a permanent alert warning on sale order form.
An image of the form should be great too (optional).
|
@aiendry-aktivsoftware Don't forget that a meaningful PR title will help reviewers. Thanks |
aiendry-aktivsoftware
force-pushed
the
16.0-mig-sale_order_warn_message
branch
from
eb65340
to
df1ad10
Compare
rousseldenis
approved these changes
Aug 30, 2023
|
Hi @aiendry-aktivsoftware could you rebase, please? THX |
|
/ocabot rebase |
|
Congratulations, PR rebased to 16.0. |
OCA-git-bot
force-pushed
the
16.0-mig-sale_order_warn_message
branch
from
df1ad10
to
37db0b0
Compare
|
@HaraldPanten Done |
|
Closing as it has been superseded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard migration to version 16.0